Skip to content

Commit c8d1dc3

Browse files
author
Ronnie Sahlberg
committed
cifs: Use help macro to get the mid header size
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2151418 commit b6b3624 It's better to use MID_HEADER_SIZE because the unfolded expression too long. No actual functional changes, minor readability improvement. Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Signed-off-by: Steve French <stfrench@microsoft.com> (cherry picked from commit b6b3624) Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
1 parent 167cdf4 commit c8d1dc3

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

fs/cifs/cifsglob.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -555,6 +555,7 @@ struct smb_version_values {
555555
#define HEADER_SIZE(server) (server->vals->header_size)
556556
#define MAX_HEADER_SIZE(server) (server->vals->max_header_size)
557557
#define HEADER_PREAMBLE_SIZE(server) (server->vals->header_preamble_size)
558+
#define MID_HEADER_SIZE(server) (HEADER_SIZE(server) - 1 - HEADER_PREAMBLE_SIZE(server))
558559

559560
/**
560561
* CIFS superblock mount flags (mnt_cifs_flags) to consider when

fs/cifs/connect.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,8 +1042,7 @@ standard_receive3(struct TCP_Server_Info *server, struct mid_q_entry *mid)
10421042

10431043
/* now read the rest */
10441044
length = cifs_read_from_socket(server, buf + HEADER_SIZE(server) - 1,
1045-
pdu_length - HEADER_SIZE(server) + 1 +
1046-
HEADER_PREAMBLE_SIZE(server));
1045+
pdu_length - MID_HEADER_SIZE(server));
10471046

10481047
if (length < 0)
10491048
return length;
@@ -1175,8 +1174,7 @@ cifs_demultiplex_thread(void *p)
11751174
server->pdu_size = pdu_length;
11761175

11771176
/* make sure we have enough to get to the MID */
1178-
if (server->pdu_size < HEADER_SIZE(server) - 1 -
1179-
HEADER_PREAMBLE_SIZE(server)) {
1177+
if (server->pdu_size < MID_HEADER_SIZE(server)) {
11801178
cifs_server_dbg(VFS, "SMB response too short (%u bytes)\n",
11811179
server->pdu_size);
11821180
cifs_reconnect(server, true);
@@ -1186,8 +1184,7 @@ cifs_demultiplex_thread(void *p)
11861184
/* read down to the MID */
11871185
length = cifs_read_from_socket(server,
11881186
buf + HEADER_PREAMBLE_SIZE(server),
1189-
HEADER_SIZE(server) - 1 -
1190-
HEADER_PREAMBLE_SIZE(server));
1187+
MID_HEADER_SIZE(server));
11911188
if (length < 0)
11921189
continue;
11931190
server->total_read += length;

0 commit comments

Comments
 (0)