regulator: qcom-labibb: Fix missing of_node_put() in qcom_labibb_regulator_probe()

athierry1 · athierry1 · commit a4a751f43992 · 2023-01-09T09:52:44.000-05:00
Bugzilla: https://bugzilla.redhat.com/2157968 commit cf34ac6 Author: Yuan Can <yuancan@huawei.com> Date: Sat Dec 3 06:21:09 2022 +0000 regulator: qcom-labibb: Fix missing of_node_put() in qcom_labibb_regulator_probe() The reg_node needs to be released through of_node_put() in the error handling path when of_irq_get_byname() failed. Fixes: 390af53 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs") Signed-off-by: Yuan Can <yuancan@huawei.com> Link: https://lore.kernel.org/r/20221203062109.115043-1-yuancan@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Adrien Thierry <athierry@redhat.com>
diff --git a/drivers/regulator/qcom-labibb-regulator.c b/drivers/regulator/qcom-labibb-regulator.c
@@ -822,6 +822,7 @@ static int qcom_labibb_regulator_probe(struct platform_device *pdev)
 			if (irq == 0)
 				irq = -EINVAL;
 
+			of_node_put(reg_node);
 			return dev_err_probe(vreg->dev, irq,
 					     "Short-circuit irq not found.\n");
 		}

Original file line number	Diff line number	Diff line change
`@@ -822,6 +822,7 @@ static int qcom_labibb_regulator_probe(struct platform_device *pdev)`
`822`	`822`	`if (irq == 0)`
`823`	`823`	`irq = -EINVAL;`
`824`	`824`
	`825`	`+ of_node_put(reg_node);`
`825`	`826`	`return dev_err_probe(vreg->dev, irq,`
`826`	`827`	`"Short-circuit irq not found.\n");`
`827`	`828`	`}`