Skip to content

Commit 8d2cf18

Browse files
committed
mmc: sdhci: Remove misleading comment about resets
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2144641 commit bd980df Author: Adrian Hunter <adrian.hunter@intel.com> Date: Mon, 26 Sep 2022 22:20:20 +0300 In SDHCI specification section 3.10.1 Error Interrupt Recovery, the flow chart shows Software Reset for CMD separately and before Software Reset for DAT, so the comment "Spec says we should do both at the same time" is not correct. Remove it. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Reviewed-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20220926192022.85660-3-adrian.hunter@intel.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Mark Salter <msalter@redhat.com>
1 parent 0ee5f15 commit 8d2cf18

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/mmc/host/sdhci.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3059,10 +3059,6 @@ static bool sdhci_request_done(struct sdhci_host *host)
30593059
/* This is to force an update */
30603060
host->ops->set_clock(host, host->clock);
30613061

3062-
/*
3063-
* Spec says we should do both at the same time, but Ricoh
3064-
* controllers do not like that.
3065-
*/
30663062
sdhci_do_reset(host, SDHCI_RESET_CMD);
30673063
sdhci_do_reset(host, SDHCI_RESET_DATA);
30683064

0 commit comments

Comments
 (0)