HID: amd_sfh: Fix warning unwind goto

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2122844
Upstream Status: since Not upstream
Tested: with the hid-tools test suite and some hardware

commit 2a33ad4
Author: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Date:   Mon Jan 2 22:00:42 2023 +0530

    HID: amd_sfh: Fix warning unwind goto

    Return directly instead of using existing goto will not cleanup
    previously allocated resources. Hence replace return with goto
    to fix warning unwind goto which cleanups previously allocated
    resources.

    Fixes: 93ce5e0 ("HID: amd_sfh: Implement SFH1.1 functionality")
    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Author: bentiss

drivers/hid/amd-sfh-hid/amd_sfh_client.c

@@ -282,7 +282,7 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
 		}
 		rc = mp2_ops->get_rep_desc(cl_idx, cl_data->report_descr[i]);
 		if (rc)
-			return rc;
+			goto cleanup;
 		mp2_ops->start(privdata, info);
 		status = amd_sfh_wait_for_response
 				(privdata, cl_data->sensor_idx[i], SENSOR_ENABLED);

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

@@ -160,7 +160,7 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata)
 		}
 		rc = mp2_ops->get_rep_desc(cl_idx, cl_data->report_descr[i]);
 		if (rc)
-			return rc;
+			goto cleanup;
 
 		writel(0, privdata->mmio + AMD_P2C_MSG(0));
 		mp2_ops->start(privdata, info);