Skip to content

Commit 2146c00

Browse files
committed
nfsd: return error if nfs4_setacl fails
Bugzilla: https://bugzilla.redhat.com/2138321 commit 01d53a8 Author: Jeff Layton <jlayton@kernel.org> Date: Mon Nov 7 06:58:41 2022 -0500 nfsd: return error if nfs4_setacl fails With the addition of POSIX ACLs to struct nfsd_attrs, we no longer return an error if setting the ACL fails. Ensure we return the na_aclerr error on SETATTR if there is one. Fixes: c0cbe70 ("NFSD: add posix ACLs to struct nfsd_attrs") Cc: Neil Brown <neilb@suse.de> Reported-by: Yongcheng Yang <yoyang@redhat.com> Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Jeffrey Layton <jlayton@redhat.com>
1 parent 945dd71 commit 2146c00

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

fs/nfsd/nfs4proc.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,6 +1143,8 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
11431143
0, (time64_t)0);
11441144
if (!status)
11451145
status = nfserrno(attrs.na_labelerr);
1146+
if (!status)
1147+
status = nfserrno(attrs.na_aclerr);
11461148
out:
11471149
nfsd_attrs_free(&attrs);
11481150
fh_drop_write(&cstate->current_fh);

0 commit comments

Comments
 (0)