Skip to content

Commit ba37336

Browse files
Merge pull request #35 from puzzle-js/css-assets
Fix for loadAssetSeries
2 parents be9365d + 7397c75 commit ba37336

File tree

4 files changed

+20
-2
lines changed

4 files changed

+20
-2
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@puzzle-js/client-lib",
33
"main": "dist/index.js",
4-
"version": "1.6.0",
4+
"version": "1.6.1",
55
"author": "<emre.kul@trendyol.com>",
66
"license": "MIT",
77
"repository": {

src/assetHelper.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ export class AssetHelper {
6666
}
6767

6868
static loadAssetSeries(assets: IPageLibAsset[], callback?: Function) {
69+
if (!assets.length && callback) {
70+
callback();
71+
}
72+
6973
for (let i = 0, p: any = Promise.resolve(); i < assets.length; i++) {
7074
p = p.then(() => new Promise(resolve => {
7175
const asset = assets[i];

test/assetHelper.spec.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,4 +130,18 @@ describe('Module - Asset Helper', () => {
130130
});
131131
});
132132

133+
it('should call given callback if assets length is 0', async (done) => {
134+
// arrange
135+
const spy = sinon.spy();
136+
const assets: IPageLibAsset[] = [];
137+
138+
// act
139+
await AssetHelper.loadAssetSeries(assets, spy);
140+
141+
// assert
142+
setTimeout(() => {
143+
expect(spy.calledOnce).to.eq(true);
144+
done();
145+
});
146+
});
133147
});

0 commit comments

Comments
 (0)