Merge pull request #54 from sharkdp/fix-regex-global-state

Reset Regex state after calling 'test', resolves #7

Author: garyb

src/Data/String/Regex.js

@@ -37,7 +37,10 @@ exports.flags = function (r) {
 
 exports.test = function (r) {
   return function (s) {
-    return r.test(s);
+    var lastIndex = r.lastIndex;
+    var result = r.test(s);
+    r.lastIndex = lastIndex;
+    return result;
   };
 };
 

src/Data/String/Regex.purs

@@ -84,7 +84,9 @@ parseFlags s =
   , unicode: contains "u" s
   }
 
--- | Returns `true` if the `Regex` matches the string.
+-- | Returns `true` if the `Regex` matches the string. In contrast to
+-- | `RegExp.prototype.test()` in JavaScript, `test` does not affect
+-- | the `lastIndex` property of the Regex.
 foreign import test :: Regex -> String -> Boolean
 
 foreign import _match :: (forall r. r -> Maybe r)

test/Test/Data/String/Regex.purs

@@ -36,3 +36,10 @@ testStringRegex = do
   assert $ split (regex' "" noFlags) "abc" == ["a", "b", "c"]
   assert $ split (regex' "b" noFlags) "" == [""]
   assert $ split (regex' "b" noFlags) "abc" == ["a", "c"]
+
+  log "test"
+  -- Ensure that we have referential transparency for calls to 'test'. No
+  -- global state should be maintained between these two calls:
+  let pattern = regex' "a" (parseFlags "g")
+  assert $ test pattern "a"
+  assert $ test pattern "a"