Migrate FFI to ES modules (#287)

* Convert foreign modules to try bundling with esbuild

* Update .eslintrc.json to ES6

* Migrated FFI to ES modules via 'lebab'

* Fix eslint issues

* Update CI purs to unstable

* Get rid of extra space from 'use strict' line

* Add changelog entry

* Update pulp to 16.0.0-0

* Update psa to 0.8.2

Co-authored-by: Cyril Sobierajewicz <sobierajewicz.cyril@gmail.com>

Author: JordanMartinez

.eslintrc.json

@@ -1,11 +1,9 @@
 {
   "parserOptions": {
-    "ecmaVersion": 5
+    "ecmaVersion": 6,
+    "sourceType": "module"
   },
   "extends": "eslint:recommended",
-  "env": {
-    "commonjs": true
-  },
   "rules": {
     "strict": [2, "global"],
     "block-scoped-var": 2,

.github/workflows/ci.yml

@@ -12,6 +12,8 @@ jobs:
       - uses: actions/checkout@v2
 
       - uses: purescript-contrib/setup-purescript@main
+        with:
+          purescript: "unstable"
 
       - uses: actions/setup-node@v1
         with:

CHANGELOG.md

@@ -5,6 +5,7 @@ Notable changes to this project are documented in this file. The format is based
 ## [Unreleased]
 
 Breaking changes:
+- Migrated FFI to ES Modules (#287 by @kl0tl and @JordanMartinez)
 
 New features:
 

package.json

@@ -7,8 +7,8 @@
   },
   "devDependencies": {
     "eslint": "^7.15.0",
-    "purescript-psa": "^0.8.0",
-    "pulp": "^15.0.0",
+    "purescript-psa": "^0.8.2",
+    "pulp": "16.0.0-0",
     "rimraf": "^3.0.2"
   }
 }

src/Control/Apply.js

@@ -1,6 +1,4 @@
-"use strict";
-
-exports.arrayApply = function (fs) {
+export const arrayApply = function (fs) {
   return function (xs) {
     var l = fs.length;
     var k = xs.length;

src/Control/Bind.js

@@ -1,6 +1,4 @@
-"use strict";
-
-exports.arrayBind = function (arr) {
+export const arrayBind = function (arr) {
   return function (f) {
     var result = [];
     for (var i = 0, l = arr.length; i < l; i++) {

src/Data/Bounded.js

@@ -1,10 +1,8 @@
-"use strict";
+export const topInt = 2147483647;
+export const bottomInt = -2147483648;
 
-exports.topInt = 2147483647;
-exports.bottomInt = -2147483648;
+export const topChar = String.fromCharCode(65535);
+export const bottomChar = String.fromCharCode(0);
 
-exports.topChar = String.fromCharCode(65535);
-exports.bottomChar = String.fromCharCode(0);
-
-exports.topNumber = Number.POSITIVE_INFINITY;
-exports.bottomNumber = Number.NEGATIVE_INFINITY;
+export const topNumber = Number.POSITIVE_INFINITY;
+export const bottomNumber = Number.NEGATIVE_INFINITY;

src/Data/Eq.js

@@ -1,18 +1,16 @@
-"use strict";
-
 var refEq = function (r1) {
   return function (r2) {
     return r1 === r2;
   };
 };
 
-exports.eqBooleanImpl = refEq;
-exports.eqIntImpl = refEq;
-exports.eqNumberImpl = refEq;
-exports.eqCharImpl = refEq;
-exports.eqStringImpl = refEq;
+export const eqBooleanImpl = refEq;
+export const eqIntImpl = refEq;
+export const eqNumberImpl = refEq;
+export const eqCharImpl = refEq;
+export const eqStringImpl = refEq;
 
-exports.eqArrayImpl = function (f) {
+export const eqArrayImpl = function (f) {
   return function (xs) {
     return function (ys) {
       if (xs.length !== ys.length) return false;

src/Data/EuclideanRing.js

@@ -1,27 +1,25 @@
-"use strict";
-
-exports.intDegree = function (x) {
+export const intDegree = function (x) {
   return Math.min(Math.abs(x), 2147483647);
 };
 
 // See the Euclidean definition in
 // https://en.m.wikipedia.org/wiki/Modulo_operation.
-exports.intDiv = function (x) {
+export const intDiv = function (x) {
   return function (y) {
     if (y === 0) return 0;
     return y > 0 ? Math.floor(x / y) : -Math.floor(x / -y);
   };
 };
 
-exports.intMod = function (x) {
+export const intMod = function (x) {
   return function (y) {
     if (y === 0) return 0;
     var yy = Math.abs(y);
     return ((x % yy) + yy) % yy;
   };
 };
 
-exports.numDiv = function (n1) {
+export const numDiv = function (n1) {
   return function (n2) {
     return n1 / n2;
   };

src/Data/Functor.js

@@ -1,6 +1,4 @@
-"use strict";
-
-exports.arrayMap = function (f) {
+export const arrayMap = function (f) {
   return function (arr) {
     var l = arr.length;
     var result = new Array(l);