Ch6 - Fix Action Self test and solution (#284)

* Revert "Add concrete test for Multiply Self append (#199)"

This reverts commit 217f6c1.

* Replacement Multiply Self concrete test

* Relax concrete tests

These still catch the incorrect instances, but are easier to
troubleshoot.

Author: milesfrain

exercises/chapter6/test/Main.purs

@@ -174,9 +174,9 @@ Note to reader: Delete this line to expand comment block -}
           test "Multiply Int append" do
             Assert.equal (act m1 (act m2 a))
               $ act (m1 <> m2) a
-          test "Multiply Int append concrete" do
-            Assert.equal 60
-              $ act (m1 <> m2) a
+          test "Multiply Int concrete" do
+            Assert.equal 15
+              $ act m1 a
         -- Multiply String is the actual exercise question
         suite "Multiply String" do
           let
@@ -187,9 +187,9 @@ Note to reader: Delete this line to expand comment block -}
           test "Multiply String append" do
             Assert.equal (act m1 (act m2 a))
               $ act (m1 <> m2) a
-          test "Multiply String append concrete" do
-            Assert.equal "foofoofoofoofoofoofoofoofoofoofoofoo"
-              $ act (m1 <> m2) a
+          test "Multiply String concrete" do
+            Assert.equal "foofoofoo"
+              $ act m1 a
       suite "Exercise - Action Class - actionArray instance" do
         suite "Multiply Array Int" do
           let
@@ -200,9 +200,9 @@ Note to reader: Delete this line to expand comment block -}
           test "Multiply Array Int append" do
             Assert.equal (act m1 (act m2 a))
               $ act (m1 <> m2) a
-          test "Multiply Array Int append concrete" do
-            Assert.equal [ 12, 24, 36 ]
-              $ act (m1 <> m2) a
+          test "Multiply Array Int concrete" do
+            Assert.equal [ 3, 6, 9 ]
+              $ act m1 a
         suite "Multiply Array String" do
           let
             a = [ "foo", "bar", "baz" ]
@@ -212,13 +212,13 @@ Note to reader: Delete this line to expand comment block -}
           test "Multiply Array String append" do
             Assert.equal (act m1 (act m2 a))
               $ act (m1 <> m2) a
-          test "Multiply Array String append concrete" do
+          test "Multiply Array String concrete" do
             Assert.equal
-              [ "foofoofoofoofoofoofoofoofoofoofoofoo"
-              , "barbarbarbarbarbarbarbarbarbarbarbar"
-              , "bazbazbazbazbazbazbazbazbazbazbazbaz"
+              [ "foofoofoo"
+              , "barbarbar"
+              , "bazbazbaz"
               ]
-              $ act (m1 <> m2) a
+              $ act m1 a
       suite "Exercise - Action Class - actionSelf instance" do
         let
           a = Self m1
@@ -228,9 +228,9 @@ Note to reader: Delete this line to expand comment block -}
         test "Multiply Self append" do
           Assert.equal (act m1 (act m2 a))
             $ act (m1 <> m2) a
-        test "Multiply Self append concrete" do
-          Assert.equal 72
-            $ act (act (m1 <> m2) a) 2
+        test "Multiply Self concrete" do
+          Assert.equal (Self (Multiply 12))
+            $ act m2 a
     suite "Exercise Group - Hashes" do
       suite "Exercise - arrayHasDuplicates" do
         test "No dupe" do

exercises/chapter6/test/no-peeking/Solutions.purs

@@ -219,11 +219,6 @@ instance actionSelf :: Monoid m => Action m (Self m) where
 -- These may also be written manualy
 derive newtype instance showSelf :: Show m => Show (Self m)
 derive newtype instance eqSelf :: Eq m => Eq (Self m)
-derive newtype instance semigroupSelf :: Semigroup m => Semigroup (Self m)
-derive newtype instance monoidSelf :: Monoid m => Monoid (Self m)
-
-instance repeatActionMultSelf :: Action (Self Multiply) Int where
-  act (Self (Multiply m)) s = m * s
 
 arrayHasDuplicates :: forall a. Hashable a => Array a -> Boolean
 arrayHasDuplicates arr =