Merge pull request #43 from iamjamestl/feature-sync-property

(MODULES-10874) Add property 'sync'

Author: GabrielNagy

REFERENCE.md

@@ -146,6 +146,10 @@ The sharesmb property. Valid values are `on`, `off`, sharemgr(1M) options
 
 The snapdir property. Valid values are `hidden`, `visible`.
 
+##### `sync`
+
+The sync property. Valid values are `standard`, `always`, `disabled`.
+
 ##### `version`
 
 The version property. Valid values are `1`, `2`, `3`, `4`, `current`.

lib/puppet/provider/zfs/zfs.rb

@@ -84,7 +84,7 @@ def container_property
    :mountpoint, :nbmand, :primarycache, :quota, :readonly,
    :recordsize, :refquota, :refreservation, :reservation,
    :secondarycache, :setuid, :sharenfs, :sharesmb,
-   :snapdir, :version, :volsize, :vscan, :xattr].each do |field|
+   :snapdir, :sync, :version, :volsize, :vscan, :xattr].each do |field|
     define_method(field) do
       zfs(:get, '-H', '-o', 'value', field, @resource[:name]).strip
     end

lib/puppet/type/zfs.rb

@@ -136,6 +136,10 @@ module Puppet
       desc 'The snapdir property. Valid values are `hidden`, `visible`.'
     end
 
+    newproperty(:sync) do
+      desc 'The sync property. Valid values are `standard`, `always`, `disabled`.'
+    end
+
     newproperty(:version) do
       desc 'The version property. Valid values are `1`, `2`, `3`, `4`, `current`.'
     end

spec/unit/type/zfs_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Puppet::Type.type(:zfs) do
-  properties = [:ensure, :mountpoint, :compression, :copies, :overlay, :quota, :reservation, :sharenfs, :snapdir]
+  properties = [:ensure, :mountpoint, :compression, :copies, :overlay, :quota, :reservation, :sharenfs, :snapdir, :sync]
 
   properties.each do |property|
     it "should have a #{property} property" do