(CONT-803) Rubocop Manual Fix 1 - Lint/ConstantDefinitionInBlock

Author: david22swan

.rubocop_todo.yml

@@ -15,13 +15,6 @@ Lint/BooleanSymbol:
     - 'lib/puppet/type/vcsrepo.rb'
     - 'spec/acceptance/clone_repo_spec.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: enums
-Lint/ConstantDefinitionInBlock:
-  Exclude:
-    - 'lib/puppet/provider/vcsrepo/svn.rb'
-
 # Offense count: 14
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:

lib/puppet/provider/vcsrepo/svn.rb

@@ -2,6 +2,8 @@
 
 require File.join(File.dirname(__FILE__), '..', 'vcsrepo')
 
+SKIP_DIRS = ['.', '..', '.svn'].freeze
+
 Puppet::Type.type(:vcsrepo).provide(:svn, parent: Puppet::Provider::Vcsrepo) do
   desc 'Supports Subversion repositories'
 
@@ -167,8 +169,6 @@ def sensitive?
     (@resource.parameters.key?(:basic_auth_password) && @resource.parameters[:basic_auth_password].sensitive) ? true : false # Check if there is a sensitive parameter
   end
 
-  SKIP_DIRS = ['.', '..', '.svn'].freeze
-
   def get_includes(directory)
     at_path do
       args = buildargs.push('info', directory)