Merge pull request #553 from puppetlabs/GH-552-home_directory_evaluation_fix

(GH-552) Fix home directory evaluation

Author: david22swan

lib/puppet/provider/vcsrepo/git.rb

@@ -650,10 +650,11 @@ def exec_git(*args)
     exec_args = {
       failonfail: true,
       combine: true,
-      custom_environment: { 'HOME' => Dir.home },
+      custom_environment: { 'HOME' => Etc.getpwuid(Process.uid).dir },
     }
+
     if @resource.value(:user) && @resource.value(:user) != Facter['id'].value
-      exec_args[:custom_environment] = { 'HOME' => Dir.home(@resource.value(:user)) }
+      exec_args[:custom_environment] = { 'HOME' => Etc.getpwnam(@resource.value(:user)).dir }
       exec_args[:uid] = @resource.value(:user)
     end
     Puppet::Util::Execution.execute([:git, args], **exec_args)