set open_ssl_port to default false instead of undef

Author: chambersmp

manifests/init.pp

@@ -353,7 +353,7 @@
   Stdlib::Host                                                         $ssl_listen_address                = $puppetdb::params::ssl_listen_address,
   Variant[Stdlib::Port::User, Pattern[/\A[0-9]+\Z/]]                   $ssl_listen_port                   = $puppetdb::params::ssl_listen_port,
   Boolean                                                              $disable_ssl                       = $puppetdb::params::disable_ssl,
-  Optional[Boolean]                                                    $open_ssl_listen_port              = $puppetdb::params::open_ssl_listen_port,
+  Boolean                                                              $open_ssl_listen_port              = $puppetdb::params::open_ssl_listen_port,
   Stdlib::Absolutepath                                                 $ssl_dir                           = $puppetdb::params::ssl_dir,
   Boolean                                                              $ssl_set_cert_paths                = $puppetdb::params::ssl_set_cert_paths,
   Stdlib::Absolutepath                                                 $ssl_cert_path                     = $puppetdb::params::ssl_cert_path,

manifests/params.pp

@@ -11,7 +11,7 @@
   $ssl_protocols             = undef
   $disable_ssl               = false
   $cipher_suites             = undef
-  $open_ssl_listen_port      = undef
+  $open_ssl_listen_port      = false
   $postgres_listen_addresses = 'localhost'
 
   $puppetdb_version          = $puppetdb::globals::version

manifests/server.pp

@@ -318,7 +318,7 @@
   Stdlib::Host                                                         $ssl_listen_address                = $puppetdb::params::ssl_listen_address,
   Variant[Stdlib::Port::User, Pattern[/\A[0-9]+\Z/]]                   $ssl_listen_port                   = $puppetdb::params::ssl_listen_port,
   Boolean                                                              $disable_ssl                       = $puppetdb::params::disable_ssl,
-  Optional[Boolean]                                                    $open_ssl_listen_port              = $puppetdb::params::open_ssl_listen_port,
+  Boolean                                                              $open_ssl_listen_port              = $puppetdb::params::open_ssl_listen_port,
   Stdlib::Absolutepath                                                 $ssl_dir                           = $puppetdb::params::ssl_dir,
   Boolean                                                              $ssl_set_cert_paths                = $puppetdb::params::ssl_set_cert_paths,
   Stdlib::Absolutepath                                                 $ssl_cert_path                     = $puppetdb::params::ssl_cert_path,

manifests/server/firewall.pp

@@ -5,7 +5,7 @@
   Variant[Stdlib::Port::User, Pattern[/\A[0-9]+\Z/]] $http_port      = $puppetdb::params::listen_port,
   Boolean                                            $open_http_port = $puppetdb::params::open_listen_port,
   Variant[Stdlib::Port::User, Pattern[/\A[0-9]+\Z/]] $ssl_port       = $puppetdb::params::ssl_listen_port,
-  Optional[Boolean]                                  $open_ssl_port  = $puppetdb::params::open_ssl_listen_port,
+  Boolean                                            $open_ssl_port  = $puppetdb::params::open_ssl_listen_port,
 ) inherits puppetdb::params {
   include firewall