From 86c407007a08dabbdfe29085145197b6c5f8e60d Mon Sep 17 00:00:00 2001 From: jordanbreen28 Date: Tue, 6 May 2025 17:11:05 +0100 Subject: [PATCH] bug: mark password as sensitive in install.json This commit marks `password` as sensitive in the install.json bolt task param metadata. This prevents password from being shown in plaintext, in the bolt logs. before: ``` Running task puppet_agent::install with '{"retry":5,"collection":"puppetcore8","version":"latest","password":"1234","_task":"puppet_agent::install"}' on [".."] ``` after: ``` Running task puppet_agent::install with '{"retry":5,"collection":"puppetcore8","version":"latest","password":"Sensitive [value redacted]","_task":"puppet_agent::install"}' on [".."] --- tasks/install.json | 1 + tasks/install_powershell.json | 1 + tasks/install_shell.json | 1 + 3 files changed, 3 insertions(+) diff --git a/tasks/install.json b/tasks/install.json index 0df11916..c279c49b 100644 --- a/tasks/install.json +++ b/tasks/install.json @@ -48,6 +48,7 @@ }, "password": { "description": "The password to use when downloading from a source location requiring authentication", + "sensitive": true, "type": "Optional[String]" } }, diff --git a/tasks/install_powershell.json b/tasks/install_powershell.json index 65b0c8bc..d13534f3 100644 --- a/tasks/install_powershell.json +++ b/tasks/install_powershell.json @@ -49,6 +49,7 @@ }, "password": { "description": "The password to use when downloading from a source location requiring authentication", + "sensitive": true, "type": "Optional[Sensitive[String[1]]]" } }, diff --git a/tasks/install_shell.json b/tasks/install_shell.json index b31139ab..df2c23e2 100644 --- a/tasks/install_shell.json +++ b/tasks/install_shell.json @@ -50,6 +50,7 @@ }, "password": { "description": "The password to use when downloading from a source location requiring authentication", + "sensitive": true, "type": "Optional[Sensitive[String[1]]]" } },