Skip to content

Commit 476d9b8

Browse files
committed
(MODULES-11365) Updates Windows nightly tests
Newer versions of Ruby used by the setup-ruby action use the ucrt C library. Puppet nightly gems are instead built with the mscvcrt library (AKA mingw), which causes This commit updates the GitHub Action that tests nightly Puppet gems to use the generic gem instead of the mingw gem, and adds a step to install the ffi dependency that was included in the mingw gem but not the generic gem.
1 parent 7a92ac2 commit 476d9b8

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/unit_tests_with_nightly_puppet_gem.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ jobs:
3131
- os: 'windows-2022'
3232
os_type: 'Windows'
3333
env_set_cmd: '$env:'
34-
gem_file: 'puppet-latest-x64-mingw32.gem'
34+
# setup-ruby uses ucrt for newer Rubies, but we only support mingw
35+
# in our Windows Puppet nightly gems. For now, we'll just install
36+
# the universal gem and manually install the ffi dependency
37+
gem_file: 'puppet-latest.gem'
38+
extra_steps: 'gem install ffi --version 1.15.5'
3539

3640
runs-on: ${{ matrix.os }}
3741
steps:
@@ -45,6 +49,7 @@ jobs:
4549

4650
- name: Install the latest nightly build of puppet${{ matrix.puppet_version }} gem
4751
run: |
52+
${{ matrix.extra_steps }}
4853
curl https://nightlies.puppet.com/downloads/gems/puppet${{ matrix.puppet_version }}-nightly/${{ matrix.gem_file }} --output puppet.gem --location
4954
gem install puppet.gem -N
5055

0 commit comments

Comments
 (0)