Skip to content

workaround for removing an empty (no fs) logical volume #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbudziszewski wants to merge 3 commits into from
Closed

workaround for removing an empty (no fs) logical volume #257

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
707d72f
workaround: only call blkid if it has a filesystem
cbudziszewski Aug 3, 2020
ccf0464
only call dmsetup on existing files as well
cbudziszewski Aug 3, 2020
ffd3ff7
Update lib/puppet/provider/logical_volume/lvm.rb
cbudziszewski Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet/provider/logical_volume/lvm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ def create

def destroy
name_escaped = "#{@resource[:volume_group].gsub('-', '--')}-#{@resource[:name].gsub('-', '--')}"
if blkid(path) =~ %r{\bTYPE=\"(swap)\"}
if File.exist?(path) and blkid(path) =~ %r{\bTYPE=\"(swap)\"}
swapoff(path)
dmsetup('remove', name_escaped)
end
dmsetup('remove', name_escaped)
lvremove('-f', path)
end

Expand Down