(maint) - remove conditional and opt for confine

jordanbreen28 · bastelfreak · web-flow · commit ebe7cec32913 · 2023-05-31T16:13:00.000+01:00
Co-authored-by: Tim Meusel &lt;tim@bastelfreak.de&gt;
diff --git a/lib/facter/lvm_support.rb b/lib/facter/lvm_support.rb
@@ -17,7 +17,7 @@
   confine lvm_support: true
 
   setcode do
-    vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30) if Facter.value(:lvm_support)
+    vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30)
 
     if vgs.nil?
       0
@@ -49,7 +49,7 @@
   confine lvm_support: true
 
   setcode do
-    pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30) if Facter.value(:lvm_support)
+    pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30)
 
     if pvs.nil?
       0

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`confine lvm_support: true`
`18`	`18`
`19`	`19`	`setcode do`
`20`		`- vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30) if Facter.value(:lvm_support)`
	`20`	`+ vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30)`
`21`	`21`
`22`	`22`	`if vgs.nil?`
`23`	`23`	`0`
`@@ -49,7 +49,7 @@`
`49`	`49`	`confine lvm_support: true`
`50`	`50`
`51`	`51`	`setcode do`
`52`		`- pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30) if Facter.value(:lvm_support)`
	`52`	`+ pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30)`
`53`	`53`
`54`	`54`	`if pvs.nil?`
`55`	`55`	`0`