Skip to content

Commit e31b29e

Browse files
committed
Manual fixes for remaining rubocop complaints
1 parent 6e090a9 commit e31b29e

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

lib/puppet/provider/volume_group/aix.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ def physical_volumes
5555
def reduce_with(volume)
5656
reducevg(@resource[:name], volume)
5757
rescue Puppet::ExecutionFailure => detail
58-
raise Puppet::Error, "Could not remove physical volume #{volume} from volume group '#{@resource[:name]}'; this physical volume may be in use and may require a manual data migration (using pvmove) before it can be removed (#{detail.message})"
58+
raise Puppet::Error, "Could not remove physical volume #{volume} from volume group '#{@resource[:name]}'; this physical volume may " \
59+
+ "be in use and may require a manual data migration (using pvmove) before it can be removed (#{detail.message})"
5960
end
6061

6162
def extend_with(volume)
@@ -64,4 +65,3 @@ def extend_with(volume)
6465
raise Puppet::Error, "Could not extend volume group '#{@resource[:name]}' with physical volume #{volume} (#{detail.message})"
6566
end
6667
end
67-

lib/puppet/provider/volume_group/lvm.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ def physical_volumes
8888
def reduce_with(volume)
8989
vgreduce(@resource[:name], volume)
9090
rescue Puppet::ExecutionFailure => detail
91-
raise Puppet::Error, "Could not remove physical volume #{volume} from volume group '#{@resource[:name]}'; this physical volume may be in use and may require a manual data migration (using pvmove) before it can be removed (#{detail.message})"
91+
raise Puppet::Error, "Could not remove physical volume #{volume} from volume group '#{@resource[:name]}'; this physical volume may " \
92+
+ "be in use and may require a manual data migration (using pvmove) before it can be removed (#{detail.message})"
9293
end
9394

9495
def extend_with(volume)

lib/puppet/type/logical_volume.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,9 @@ def insync?(is)
206206
desc "An optimization in lvcreate, at least on Linux."
207207
end
208208
newparam(:region_size) do
209-
desc "A mirror is divided into regions of this size (in MB), the mirror log uses this granularity to track which regions are in sync. CAN NOT BE CHANGED on already mirrored volume. Take your mirror size in terabytes and round up that number to the next power of 2, using that number as the -R argument."
209+
desc "A mirror is divided into regions of this size (in MB), the mirror log uses this granularity to track which regions are in sync. "\
210+
+"CAN NOT BE CHANGED on already mirrored volume. Take your mirror size in terabytes and round up that number to the next power of 2, " \
211+
+"using that number as the -R argument."
210212
validate do |value|
211213
unless value.to_s =~ /^[0-9]+$/i
212214
raise ArgumentError , "#{value} is not a valid region size in MB."

lib/puppet_x/lvm/output.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module Puppet_X
22
module LVM
3+
# Work with LVM Output
34
class Output
45
# Parses the results of LVMs commands. This does not handle when columns
56
# have no data and therefore these columns should be avoided. It returns
@@ -8,7 +9,7 @@ class Output
89
# "foo_bar" into "bar"
910
def self.parse(key,columns,data)
1011
results = {}
11-
12+
1213
# Remove prefixes
1314
columns = remove_prefixes(columns)
1415
key = remove_prefix(key)
@@ -20,7 +21,7 @@ def self.parse(key,columns,data)
2021
values.delete(key)
2122
results[current_key] = values
2223
end
23-
24+
2425
results
2526
end
2627

@@ -35,4 +36,4 @@ def self.remove_prefix(item)
3536
end
3637
end
3738
end
38-
end
39+
end

0 commit comments

Comments
 (0)