Added support for LVM Thin Volumes

Author: glorpen

README.md

@@ -199,7 +199,7 @@ resources out yourself.
 * size_is_minsize (Parameter) Default value: `false` - Set to true if the ‘size’ parameter specified, is just the minimum size you need (if the LV found is larger then the size requests this is just logged not causing a FAIL)
 * stripes (Parameter) - The number of stripes to allocate for the new logical volume.
 * stripesize (Parameter) - The stripesize to use for the new logical volume.
-* thinpool (Parameter) - Default value: `false` - Set to true to create a thin pool
+* thinpool (Parameter) - Default value: `false` - Set to true to create a thin pool or to pool name to create thin volume
 * volume_group (Parameter) - The volume group name associated with this logical volume. This will automatically set this volume group as a dependency, but it must be defined elsewhere using the volume_group resource type.
 
 ### physical_volume

lib/puppet/provider/logical_volume/lvm.rb

@@ -54,12 +54,17 @@ def self.get_logical_volume_properties(logical_volumes_line)
     def create
         args = []
 
-        args.push('-n', @resource[:name]) unless @resource[:thinpool]
+        args.push('-n', @resource[:name]) unless @resource[:thinpool] == true
+
+        size_option = '--size'
+        if @resource[:thinpool].is_a? String
+          size_option = '--virtualsize'
+        end
 
         if @resource[:size]
-            args.push('--size', @resource[:size])
+            args.push(size_option, @resource[:size])
         elsif @resource[:initial_size]
-            args.push('--size', @resource[:initial_size])
+            args.push(size_option, @resource[:initial_size])
         end
         if @resource[:extents]
             args.push('--extents', @resource[:extents])
@@ -120,7 +125,11 @@ def create
 
         if @resource[:thinpool]
             args.push('--thin')
-            args << @resource[:volume_group] + "/" + @resource[:name]
+            if @resource[:thinpool].is_a? String
+              args << @resource[:volume_group] + "/" + @resource[:thinpool]
+            else
+              args << @resource[:volume_group] + "/" + @resource[:name]
+            end
         else
             args << @resource[:volume_group]
         end

lib/puppet/type/logical_volume.rb

@@ -76,9 +76,23 @@ def insync?(is)
     end
   end
 
-  newparam(:thinpool, :boolean => true, :parent => Puppet::Parameter::Boolean) do
-    desc "Set to true to create a thin pool"
-    defaultto false 
+  newparam(:thinpool) do
+    desc "Set to true to create a thin pool or to pool name to create thin volume"
+    defaultto false
+    validate do |value|
+      unless value.is_a? String or [:true, true, "true", :false, false, "false"].include?(value)
+        raise ArgumentError , "thinpool must be either be true, false or string"
+      end
+    end
+    munge do |value|
+      if [:true, true, "true"].include?(value)
+        true
+      elsif value.is_a? String and value != "false"
+        value
+      else
+        false
+      end
+    end
   end
 
   newparam(:poolmetadatasize) do
@@ -194,4 +208,9 @@ def insync?(is)
   autorequire(:volume_group) do
     @parameters[:volume_group].value
   end
+  autorequire(:logical_volume) do
+    if @parameters[:thinpool].is_a? String
+      @parameters[:thinpool].value
+    end
+  end
 end

manifests/logical_volume.pp

@@ -2,32 +2,32 @@
 #
 define lvm::logical_volume (
   $volume_group,
-  $size                             = undef,
-  $initial_size                     = undef,
-  Enum['absent', 'present'] $ensure = present,
-  $options                          = 'defaults',
-  $pass                             = '2',
-  $dump                             = '0',
-  $fs_type                          = 'ext4',
-  $mkfs_options                     = undef,
-  Stdlib::Absolutepath $mountpath   = "/${name}",
-  Boolean $mountpath_require        = false,
-  Boolean $mounted                  = true,
-  Boolean $createfs                 = true,
-  $extents                          = undef,
-  $stripes                          = undef,
-  $stripesize                       = undef,
-  $readahead                        = undef,
-  $range                            = undef,
-  $size_is_minsize                  = undef,
-  $type                             = undef,
-  $thinpool                         = false,
-  $poolmetadatasize                 = undef,
-  $mirror                           = undef,
-  $mirrorlog                        = undef,
-  $no_sync                          = undef,
-  $region_size                      = undef,
-  $alloc                            = undef,
+  $size                              = undef,
+  $initial_size                      = undef,
+  Enum['absent', 'present'] $ensure  = present,
+  $options                           = 'defaults',
+  $pass                              = '2',
+  $dump                              = '0',
+  $fs_type                           = 'ext4',
+  $mkfs_options                      = undef,
+  Stdlib::Absolutepath $mountpath    = "/${name}",
+  Boolean $mountpath_require         = false,
+  Boolean $mounted                   = true,
+  Boolean $createfs                  = true,
+  $extents                           = undef,
+  $stripes                           = undef,
+  $stripesize                        = undef,
+  $readahead                         = undef,
+  $range                             = undef,
+  $size_is_minsize                   = undef,
+  $type                              = undef,
+  Variant[Boolean, String] $thinpool = false,
+  $poolmetadatasize                  = undef,
+  $mirror                            = undef,
+  $mirrorlog                         = undef,
+  $no_sync                           = undef,
+  $region_size                       = undef,
+  $alloc                             = undef,
 ) {
 
   $lvm_device_path = "/dev/${volume_group}/${name}"