Merge pull request #303 from puppetlabs/maint-rubocop_fixes

(maint) - fix rubocop

Author: GSPatton

.github/workflows/ci.yml

@@ -22,6 +22,8 @@ jobs:
     steps:
       - name: "Checkout"
         uses: "actions/checkout@v3"
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}}
 
       - name: "Setup ruby"
         uses: "ruby/setup-ruby@v1"
@@ -50,6 +52,8 @@ jobs:
 
       - name: "Checkout"
         uses: "actions/checkout@v3"
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}}
 
       - name: "Setup ruby"
         uses: "ruby/setup-ruby@v1"

lib/facter/lvm_support.rb

@@ -35,9 +35,7 @@
     setcode do
       pvs = Facter::Core::Execution.execute("vgs -o pv_name #{vg} 2>/dev/null", timeout: 30)
       res = nil
-      unless pvs.nil?
-        res = pvs.split("\n").select { |l| l =~ %r{^\s+/} }.map(&:strip).sort.join(',')
-      end
+      res = pvs.split("\n").grep(%r{^\s+/}).map(&:strip).sort.join(',') unless pvs.nil?
       res
     end
   end