Skip to content

Commit 5ecb4a1

Browse files
committed
Fix some more rubocop issues; regenerate TODO file
1 parent 6ae5c1d commit 5ecb4a1

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

.rubocop_todo.yml

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2019-11-01 14:59:36 +0000 using RuboCop version 0.49.1.
3+
# on 2019-11-01 16:00:27 +0000 using RuboCop version 0.49.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -30,12 +30,6 @@ Lint/Void:
3030
Exclude:
3131
- 'spec/unit/facter/lvm_support_spec.rb'
3232

33-
# Offense count: 3
34-
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
35-
# URISchemes: http, https
36-
Metrics/LineLength:
37-
Max: 309
38-
3933
# Offense count: 252
4034
# Configuration parameters: AssignmentOnly.
4135
RSpec/InstanceVariable:
@@ -54,11 +48,6 @@ RSpec/MultipleDescribes:
5448
Exclude:
5549
- 'spec/unit/facter/lvm_support_spec.rb'
5650

57-
# Offense count: 4
58-
RSpec/RepeatedDescription:
59-
Exclude:
60-
- 'spec/unit/type/logical_volume_spec.rb'
61-
6251
# Offense count: 2
6352
RSpec/ScatteredSetup:
6453
Exclude:
@@ -83,13 +72,6 @@ Style/ClassAndModuleChildren:
8372
Exclude:
8473
- 'lib/puppet_x/lvm/output.rb'
8574

86-
# Offense count: 1
87-
Style/Documentation:
88-
Exclude:
89-
- 'lib/puppet/parser/functions/**/*'
90-
- 'spec/**/*'
91-
- 'lib/puppet_x/lvm/output.rb'
92-
9375
# Offense count: 1
9476
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
9577
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS

spec/unit/type/logical_volume_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208
}.not_to raise_error
209209
end
210210

211-
it 'invalid stripesize raises error' do
211+
it 'string stripesize raises error' do
212212
expect {
213213
resource = Puppet::Type.type(:logical_volume).new(
214214
name: 'bert',
@@ -258,7 +258,7 @@
258258
}.not_to raise_error
259259
end
260260

261-
it 'invalid readahead raises error' do
261+
it 'string readahead raises error' do
262262
expect {
263263
resource = Puppet::Type.type(:logical_volume).new(
264264
name: 'bert',
@@ -333,7 +333,7 @@
333333
}.not_to raise_error
334334
end
335335

336-
it 'region_size with invalid value throws error' do
336+
it 'region_size with string value throws error' do
337337
expect {
338338
resource = Puppet::Type.type(:logical_volume).new(
339339
name: 'fred',

0 commit comments

Comments
 (0)