Adding the 30 second timeout for facts/test fix

Author: tphoney

lib/facter/lvm_support.rb

@@ -15,10 +15,7 @@
 Facter.add('lvm_vgs') do
   confine :lvm_support => true
 
-  lvm = Facter.value(:lvm_support)
-  if lvm 
-    vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30)
-  end
+  vgs = Facter::Core::Execution.execute('vgs -o name --noheadings 2>/dev/null', timeout: 30)
   if vgs.nil?
     setcode { 0 }
   else
@@ -49,10 +46,7 @@
 Facter.add('lvm_pvs') do
   confine :lvm_support => true
 
-  lvm = Facter.value(:lvm_support)
-  if lvm 
-    pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30)
-  end
+  pvs = Facter::Core::Execution.execute('pvs -o name --noheadings 2>/dev/null', timeout: 30)
   if pvs.nil?
     setcode { 0 }
   else

spec/unit/facter/lvm_support_spec.rb

@@ -52,9 +52,9 @@
   context 'when there is lvm support' do
     context 'when there are no vgs' do
       it 'should be set to 0' do
-        Facter.fact(:lvm_support).expects(:value).at_least(1).returns(true)
         Facter::Core::Execution.stubs(:execute) # All other calls
         Facter::Core::Execution.expects(:execute).at_least(1).with('vgs -o name --noheadings 2>/dev/null', timeout: 30).returns(nil)
+        Facter.fact(:lvm_support).expects(:value).at_least(1).returns(true)
         Facter.value(:lvm_vgs).should == 0
       end
     end