Merge pull request #185 from LMAX-Exchange/master

Removing the 'extent size' check in logical_volume provider

Author: eputnam

lib/puppet/provider/logical_volume/lvm.rb

@@ -77,7 +77,7 @@ def create
             args.push('--stripesize', @resource[:stripesize])
         end
 
-	
+
 
         if @resource[:poolmetadatasize]
             args.push('--poolmetadatasize', @resource[:poolmetadatasize])
@@ -197,11 +197,6 @@ def size=(new_size)
                 fail( "Decreasing the size requires manual intervention (#{new_size} < #{current_size})" )
             end
         else
-            ## Check if new size fits the extend blocks
-            if new_size_bytes * lvm_size_units[new_size_unit] % vg_extent_size != 0
-                fail( "Cannot extend to size #{new_size} because VG extent size is #{vg_extent_size} KB" )
-            end
-
             lvextend( '-L', new_size, path) || fail( "Cannot extend to size #{new_size} because lvextend failed." )
 
             unless @resource[:resize_fs] == :false or @resource[:resize_fs] == false or @resource[:resize_fs] == 'false'

spec/unit/puppet/provider/logical_volume/lvm_spec.rb

@@ -13,7 +13,7 @@
   LV      VG       Attr       LSize   Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
   lv_root VolGroup -wi-ao----  18.54g
   lv_swap VolGroup -wi-ao---- 992.00m
-  data    data     -wi-ao---- 992.00m  
+  data    data     -wi-ao---- 992.00m
   EOS
 
   describe 'self.instances' do
@@ -190,7 +190,7 @@
           @provider.create
           @provider.expects(:lvs).with('--noheading', '--unit', 'g', '/dev/myvg/mylv').returns(' 1.00g').at_least_once
           @provider.expects(:lvs).with('--noheading', '-o', 'vg_extent_size', '--units', 'k', '/dev/myvg/mylv').returns(' 1000.00k')
-          proc { @provider.size = '1.15g' }.should raise_error(Puppet::Error, /extent/)
+          proc { @provider.size = '1.15g' }.should raise_error(Puppet::Error)
         end
       end
     end