Merge pull request #1095 from ahrefs/main

debian: service: fix `ensure` parameter usage

Author: LukasAud

manifests/linux/debian.pp

@@ -34,7 +34,7 @@
   # This isn't a real service/daemon. The start action loads rules, so just
   # needs to be called on system boot.
   service { $service_name:
-    ensure    => undef,
+    ensure    => $ensure,
     enable    => $enable,
     hasstatus => true,
     require   => Package[$package_name],

spec/unit/classes/firewall_linux_debian_spec.rb

@@ -19,7 +19,7 @@
     }
     it {
       is_expected.to contain_service('netfilter-persistent').with(
-        ensure: nil,
+        ensure: 'running',
         enable: 'true',
         require: 'Package[iptables-persistent]',
       )
@@ -43,6 +43,23 @@
     }
   end
 
+  context 'with Debian 10, ensure => stopped' do
+    let(:facts) do
+      {
+        osfamily: 'Debian',
+        operatingsystem: 'Debian',
+        operatingsystemrelease: '10.0',
+      }
+    end
+    let(:params) { { ensure: 'stopped' } }
+
+    it {
+      is_expected.to contain_service('netfilter-persistent').with(
+        ensure: 'stopped',
+      )
+    }
+  end
+
   context 'with Debian 11' do
     let(:facts) do
       {
@@ -59,7 +76,7 @@
     }
     it {
       is_expected.to contain_service('netfilter-persistent').with(
-        ensure: nil,
+        ensure: 'running',
         enable: 'true',
         require: 'Package[iptables-persistent]',
       )
@@ -83,6 +100,23 @@
     }
   end
 
+  context 'with Debian 11, ensure => stopped' do
+    let(:facts) do
+      {
+        osfamily: 'Debian',
+        operatingsystem: 'Debian',
+        operatingsystemrelease: '10.0',
+      }
+    end
+    let(:params) { { ensure: 'stopped' } }
+
+    it {
+      is_expected.to contain_service('netfilter-persistent').with(
+        ensure: 'stopped',
+      )
+    }
+  end
+
   context 'with Debian unstable' do
     let(:facts) do
       {
@@ -99,10 +133,44 @@
     }
     it {
       is_expected.to contain_service('netfilter-persistent').with(
-        ensure: nil,
+        ensure: 'running',
         enable: 'true',
         require: 'Package[netfilter-persistent]',
       )
     }
   end
+
+  context 'with Debian unstable, enable => false' do
+    let(:facts) do
+      {
+        osfamily: 'Debian',
+        operatingsystem: 'Debian',
+        operatingsystemrelease: 'unstable',
+      }
+    end
+    let(:params) { { enable: 'false' } }
+
+    it {
+      is_expected.to contain_service('netfilter-persistent').with(
+        enable: 'false',
+      )
+    }
+  end
+
+  context 'with Debian unstable, ensure => stopped' do
+    let(:facts) do
+      {
+        osfamily: 'Debian',
+        operatingsystem: 'Debian',
+        operatingsystemrelease: '10.0',
+      }
+    end
+    let(:params) { { ensure: 'stopped' } }
+
+    it {
+      is_expected.to contain_service('netfilter-persistent').with(
+        ensure: 'stopped',
+      )
+    }
+  end
 end