(CONT-773) Rubocop Unsafe Auto Fixes 4-5

- Style/GlobalStdStream
- Style/SlicingWithRange

Author: david22swan

.rubocop_todo.yml

@@ -128,19 +128,7 @@ Security/Open:
   Exclude:
     - 'lib/puppet/provider/apt_key/apt_key.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/GlobalStdStream:
-  Exclude:
-    - 'tasks/init.rb'
-
 # Offense count: 1
 Style/MixinUsage:
   Exclude:
     - 'spec/spec_helper.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/SlicingWithRange:
-  Exclude:
-    - 'lib/puppet/provider/apt_key/apt_key.rb'

lib/puppet/provider/apt_key/apt_key.rb

@@ -92,8 +92,8 @@ def self.key_line_hash(pub_line, fpr_line)
     fingerprint = fpr_split.last
     return_hash = {
       key_fingerprint: fingerprint,
-      key_long: fingerprint[-16..-1], # last 16 characters of fingerprint
-      key_short: fingerprint[-8..-1], # last 8 characters of fingerprint
+      key_long: fingerprint[-16..], # last 16 characters of fingerprint
+      key_short: fingerprint[-8..], # last 8 characters of fingerprint
       key_size: pub_split[2],
       key_type: nil,
       key_created: Time.at(pub_split[5].to_i),

tasks/init.rb

@@ -21,7 +21,7 @@ def apt_get(action)
   { status: stdout.strip }
 end
 
-params = JSON.parse(STDIN.read)
+params = JSON.parse($stdin.read)
 action = params['action']
 
 begin