(CONT-773) Rubocop Manual Fix 4 - Performance/CollectionLiteralInLoop

david22swan · david22swan · commit 46c94754d754 · 2023-04-26T17:10:38.000+01:00
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -32,12 +32,6 @@ Metrics/MethodLength:
 Metrics/PerceivedComplexity:
   Max: 12
 
-# Offense count: 1
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'spec/classes/apt_update_spec.rb'
-
 # Offense count: 6
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
diff --git a/spec/classes/apt_update_spec.rb b/spec/classes/apt_update_spec.rb
@@ -154,7 +154,8 @@
 
   ['daily', 'weekly'].each do |update_frequency|
     context "when apt::update['frequency'] has the value of #{update_frequency}" do
-      { 'we are due for a run' => 1_406_660_561, 'the update-success-stamp file does not exist' => -1 }.each_pair do |desc, factval|
+      pair = { 'we are due for a run' => 1_406_660_561, 'the update-success-stamp file does not exist' => -1 }
+      pair.each_pair do |desc, factval|
         context "when $apt_update_last_success indicates #{desc}" do
           let(:facts) do
             {

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@`
`154`	`154`
`155`	`155`	`['daily', 'weekly'].each do \|update_frequency\|`
`156`	`156`	`context "when apt::update['frequency'] has the value of #{update_frequency}" do`
`157`		`- { 'we are due for a run' => 1_406_660_561, 'the update-success-stamp file does not exist' => -1 }.each_pair do \|desc, factval\|`
	`157`	`+ pair = { 'we are due for a run' => 1_406_660_561, 'the update-success-stamp file does not exist' => -1 }`
	`158`	`+ pair.each_pair do \|desc, factval\|`
`158`	`159`	`context "when $apt_update_last_success indicates #{desc}" do`
`159`	`160`	`let(:facts) do`
`160`	`161`	`{`