Add all safe auto corrects

Author: DavidS

spec/acceptance/itk_spec.rb

@@ -7,7 +7,7 @@
   service_name = 'apache2'
   variant = :prefork
 when 'redhat'
-  unless os[:release] =~ %r{^5}
+  unless %r{^5}.match?(os[:release])
     variant = (os[:release].to_i >= 7) ? :prefork : :itk_only
     service_name = 'httpd'
   end

spec/acceptance/vhost_spec.rb

@@ -1083,7 +1083,7 @@ class { 'apache': }
       }
     MANIFEST
     it 'applies cleanly' do
-      pp += "\nclass { 'apache::mod::actions': }" if os[:family] =~ %r{debian|suse|ubuntu|sles}
+      pp += "\nclass { 'apache::mod::actions': }" if %r{debian|suse|ubuntu|sles}.match?(os[:family])
       apply_manifest(pp, catch_failures: true)
     end
 

spec/spec_helper_acceptance_local.rb

@@ -34,7 +34,7 @@ def print_parsing_errors
   end
   c.before :suite do
     # Make sure selinux is disabled so the tests work.
-    LitmusHelper.instance.run_shell('setenforce 0', expect_failures: true) if os[:family] =~ %r{redhat|oracle}
+    LitmusHelper.instance.run_shell('setenforce 0', expect_failures: true) if %r{redhat|oracle}.match?(os[:family])
 
     LitmusHelper.instance.run_shell('puppet module install stahnma/epel')
     pp = <<-PUPPETCODE

spec/unit/provider/a2mod/gentoo_spec.rb

@@ -10,7 +10,7 @@
   end
 
   [:conf_file, :instances, :modules, :initvars, :conf_file, :clear].each do |method|
-    it "should respond to the class method #{method}" do
+    it "responds to the class method #{method}" do
       expect(provider_class).to respond_to(method)
     end
   end

spec/util/_resources/test_metadata_json.rb

@@ -85,4 +85,4 @@
   "pdk-version": "1.17.0",
   "template-url": "https://github.com/puppetlabs/pdk-templates#main",
   "template-ref": "heads/main-0-g095317c"
-}'.freeze
+}'

spec/util/apache_mod_platform_support_spec.rb

@@ -105,7 +105,7 @@
       context 'after parsing the metadata.json' do
         expected_compatible_platform_versions.each do |os, vers|
           vers.each do |ver|
-            it "should state #{os} version #{ver} IS a compatible platform" do
+            it "states #{os} version #{ver} IS a compatible platform" do
               ampc.register_running_platform(family: os, version: ver)
               expect(ampc.mod_supported_on_platform?(foobar_mod)).to be(true)
             end

util/apache_mod_platform_support.rb

@@ -94,7 +94,7 @@ def extract_os_ver_pairs(line)
     platforms_versions = {}
     os_ver_groups = line.delete(' ').downcase
     # E.g. "debian:5,6;centos:5;sles:11sp1,12;scientific:all;ubuntu:14.04,16.04"
-    if %r{^((?:\w+:(?:(?:\d+(?:\.\d+|sp\d+)?|all),?)+;?)+)$}i =~ os_ver_groups
+    if %r{^((?:\w+:(?:(?:\d+(?:\.\d+|sp\d+)?|all),?)+;?)+)$}i.match?(os_ver_groups)
       os_ver_groups.split(';').each do |os_vers|
         os, vers = os_vers.split(':')
         vers.gsub!(%r{sp\d+}, '') # Remove SP ver as we cannot determine this level of granularity from values from Litmus
@@ -106,7 +106,7 @@ def extract_os_ver_pairs(line)
 
   def process_line(line)
     data = {}
-    return data unless line =~ %r{@note\sUnsupported\splatforms?:\s?|class\sapache::mod}i
+    return data unless %r{@note\sUnsupported\splatforms?:\s?|class\sapache::mod}i.match?(line)
     if (match = %r{@note\sUnsupported\splatforms?:\s?(?<os_vers>.*)$}i.match(line))
       data[:type] = :unsupported_platform_declaration
       data[:value] = match[:os_vers]