(PUP-11993) Style/RedundantPercentQ

This commit enables the Style/RedundantPercentQ cop and fixes 12
autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -668,19 +668,6 @@ Style/RedundantFetchBlock:
 Style/RedundantInterpolation:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantPercentQ:
-  Exclude:
-    - 'lib/puppet/defaults.rb'
-    - 'lib/puppet/indirector/catalog/store_configs.rb'
-    - 'lib/puppet/indirector/facts/store_configs.rb'
-    - 'lib/puppet/indirector/node/store_configs.rb'
-    - 'lib/puppet/indirector/resource/store_configs.rb'
-    - 'lib/puppet/provider/package/dpkg.rb'
-    - 'lib/puppet/provider/package/rpm.rb'
-    - 'lib/puppet/type.rb'
-    - 'lib/puppet/util/at_fork/solaris.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/RedundantRegexpCharacterClass:
   Exclude:

lib/puppet/defaults.rb

@@ -77,7 +77,7 @@ def self.default_vendormoduledir
   #   see the docs for Settings.define_settings
   ############################################################################################
 
-  AS_DURATION = %q{This setting can be a time interval in seconds (30 or 30s), minutes (30m), hours (6h), days (2d), or years (5y).}
+  AS_DURATION = 'This setting can be a time interval in seconds (30 or 30s), minutes (30m), hours (6h), days (2d), or years (5y).'
 
   # @api public
   # @param args [Puppet::Settings] the settings object to define default settings for

lib/puppet/indirector/catalog/store_configs.rb

@@ -4,5 +4,5 @@
 require_relative '../../../puppet/resource/catalog'
 
 class Puppet::Resource::Catalog::StoreConfigs < Puppet::Indirector::StoreConfigs
-  desc %q(Part of the "storeconfigs" feature. Should not be directly set by end users.)
+  desc 'Part of the "storeconfigs" feature. Should not be directly set by end users.'
 end

lib/puppet/indirector/facts/store_configs.rb

@@ -4,7 +4,7 @@
 require_relative '../../../puppet/indirector/store_configs'
 
 class Puppet::Node::Facts::StoreConfigs < Puppet::Indirector::StoreConfigs
-  desc %q(Part of the "storeconfigs" feature. Should not be directly set by end users.)
+  desc 'Part of the "storeconfigs" feature. Should not be directly set by end users.'
 
   def allow_remote_requests?
     false

lib/puppet/indirector/node/store_configs.rb

@@ -4,5 +4,5 @@
 require_relative '../../../puppet/node'
 
 class Puppet::Node::StoreConfigs < Puppet::Indirector::StoreConfigs
-  desc %q(Part of the "storeconfigs" feature. Should not be directly set by end users.)
+  desc 'Part of the "storeconfigs" feature. Should not be directly set by end users.'
 end

lib/puppet/indirector/resource/store_configs.rb

@@ -6,7 +6,7 @@
 class Puppet::Resource::StoreConfigs < Puppet::Indirector::StoreConfigs
   include Puppet::Resource::Validator
 
-  desc %q(Part of the "storeconfigs" feature. Should not be directly set by end users.)
+  desc 'Part of the "storeconfigs" feature. Should not be directly set by end users.'
 
   def allow_remote_requests?
     false

lib/puppet/provider/package/dpkg.rb

@@ -45,8 +45,8 @@ def self.instances
 
   # Note: self:: is required here to keep these constants in the context of what will
   # eventually become this Puppet::Type::Package::ProviderDpkg class.
-  self::DPKG_QUERY_FORMAT_STRING = %q('${Status} ${Package} ${Version}\\n')
-  self::DPKG_QUERY_PROVIDES_FORMAT_STRING = %q('${Status} ${Package} ${Version} [${Provides}]\\n')
+  self::DPKG_QUERY_FORMAT_STRING = "'${Status} ${Package} ${Version}\\n'"
+  self::DPKG_QUERY_PROVIDES_FORMAT_STRING = "'${Status} ${Package} ${Version} [${Provides}]\\n'"
   self::FIELDS_REGEX = %r{^'?(\S+) +(\S+) +(\S+) (\S+) (\S*)$}
   self::FIELDS_REGEX_WITH_PROVIDES = %r{^'?(\S+) +(\S+) +(\S+) (\S+) (\S*) \[.*\]$}
   self::FIELDS = [:desired, :error, :status, :name, :ensure]

lib/puppet/provider/package/rpm.rb

@@ -24,7 +24,7 @@
   # Note: self:: is required here to keep these constants in the context of what will
   # eventually become this Puppet::Type::Package::ProviderRpm class.
   # The query format by which we identify installed packages
-  self::NEVRA_FORMAT = %q(%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n)
+  self::NEVRA_FORMAT = '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n'
   self::NEVRA_REGEX  = %r{^'?(\S+) (\S+) (\S+) (\S+) (\S+)$}
   self::NEVRA_FIELDS = [:name, :epoch, :version, :release, :arch]
   self::MULTIVERSION_SEPARATOR = "; "

lib/puppet/type.rb

@@ -1375,7 +1375,7 @@ def properties_to_audit(list)
   end
 
   newmetaparam(:alias) do
-    desc %q{Creates an alias for the resource.  Puppet uses this internally when you
+    desc "Creates an alias for the resource.  Puppet uses this internally when you
       provide a symbolic title and an explicit namevar value:
 
           file { 'sshdconfig':
@@ -1411,7 +1411,7 @@ def properties_to_audit(list)
       There's no way here for the Puppet parser to know that these two stanzas
       should be affecting the same file.
 
-      }
+      "
 
     munge do |aliases|
       aliases = [aliases] unless aliases.is_a?(Array)

lib/puppet/util/at_fork/solaris.rb

@@ -47,8 +47,8 @@ class Puppet::Util::AtFork::Solaris
   end
 
   CTFS_PR_ROOT = File.join('', %w[system contract process])
-  CTFS_PR_TEMPLATE = File.join(CTFS_PR_ROOT, %q(template))
-  CTFS_PR_LATEST = File.join(CTFS_PR_ROOT, %q(latest))
+  CTFS_PR_TEMPLATE = File.join(CTFS_PR_ROOT, 'template')
+  CTFS_PR_LATEST = File.join(CTFS_PR_ROOT, 'latest')
 
   CT_PR_PGRPONLY = 0x4
   CT_PR_EV_HWERR = 0x20
@@ -129,7 +129,7 @@ def abandon_latest_child_contract
     return if ctid.nil?
 
     begin
-      ctl = File.new(File.join(CTFS_PR_ROOT, ctid.to_s, %q(ctl)), File::WRONLY)
+      ctl = File.new(File.join(CTFS_PR_ROOT, ctid.to_s, 'ctl'), File::WRONLY)
 
       begin
         raise_if_error { ct_ctl_abandon(ctl.fileno) }