(PUP-11993) Style/NonNilCheck

This commit enables the Style/NonNilCheck cop and fixes 4
autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -629,15 +629,6 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: IncludeSemanticChanges.
-Style/NonNilCheck:
-  Exclude:
-    - 'lib/puppet/forge.rb'
-    - 'lib/puppet/http/session.rb'
-    - 'lib/puppet/network/http/request.rb'
-    - 'lib/puppet/provider/package/pip.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/Not:
   Enabled: false

lib/puppet/forge.rb

@@ -235,7 +235,7 @@ def unpack(file, destination)
     end
 
     def deprecated?
-      @data['module'] && (@data['module']['deprecated_at'] != nil)
+      @data['module'] && (!@data['module']['deprecated_at'].nil?)
     end
   end
 

lib/puppet/http/session.rb

@@ -52,7 +52,7 @@ def route_to(name, url: nil, ssl_context: nil)
     raise ArgumentError, "Unknown service #{name}" unless Puppet::HTTP::Service.valid_name?(name)
 
     # short circuit if explicit URL host & port given
-    if url && url.host != nil && !url.host.empty?
+    if url && !url.host.nil? && !url.host.empty?
       service = Puppet::HTTP::Service.create_service(@client, self, name, url.host, url.port)
       service.connect(ssl_context: ssl_context)
       return service

lib/puppet/network/http/request.rb

@@ -78,6 +78,6 @@ def response_formatters_for(supported_formats, default_accepted_formats = nil)
 
   def valid_network_format?(format)
     # YAML in network requests is not supported. See http://links.puppet.com/deprecate_yaml_on_network
-    format != nil && format.name != :yaml && format.name != :b64_zlib_yaml
+    !format.nil? && format.name != :yaml && format.name != :b64_zlib_yaml
   end
 end

lib/puppet/provider/package/pip.rb

@@ -32,7 +32,7 @@ def self.specificity
   # Required by Puppet::Provider::Package::Targetable::resource_or_provider_command
   def self.provider_command
     # Ensure pip can upgrade pip, which usually puts pip into a new path /usr/local/bin/pip (compared to /usr/bin/pip)
-    self.cmd.map { |c| which(c) }.find { |c| c != nil }
+    self.cmd.map { |c| which(c) }.find { |c| !c.nil? }
   end
 
   def self.cmd