(PUP-11993) Style/NestedTernaryOperator

This commit enables the Style/NestedTernaryOperator cop and fixes
78 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -629,19 +629,6 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/NestedTernaryOperator:
-  Exclude:
-    - 'lib/puppet/external/dot.rb'
-    - 'lib/puppet/module_tool/shared_behaviors.rb'
-    - 'lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb'
-    - 'lib/puppet/pops/lookup/hiera_config.rb'
-    - 'lib/puppet/pops/parser/lexer2.rb'
-    - 'lib/puppet/pops/types/string_converter.rb'
-    - 'lib/puppet/pops/types/type_factory.rb'
-    - 'lib/puppet/pops/types/types.rb'
-    - 'lib/puppet/util/log.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, MinBodyLength.
 # SupportedStyles: skip_modifier_ifs, always

lib/puppet/external/dot.rb

@@ -196,16 +196,18 @@ def pop
     def to_s(t = '')
       # This code is totally incomprehensible; it needs to be replaced!
 
-      label = @options['shape'] != 'record' && @ports.length == 0 ?
-          @options['label'] ?
-            t + $tab + "label = #{stringify(@options['label'])}\n" :
-            '' :
-          t + $tab + 'label = "' + " \\\n" +
-            t + $tab2 + "#{stringify(@options['label'])}| \\\n" +
-            @ports.collect { |i|
-              t + $tab2 + i.to_s
-            }.join("| \\\n") + " \\\n" +
-            t + $tab + '"' + "\n"
+      label = if @options['shape'] != 'record' && @ports.length == 0
+                @options['label'] ?
+                            t + $tab + "label = #{stringify(@options['label'])}\n" :
+                            ''
+              else
+                t + $tab + 'label = "' + " \\\n" +
+                  t + $tab2 + "#{stringify(@options['label'])}| \\\n" +
+                  @ports.collect { |i|
+                    t + $tab2 + i.to_s
+                  }.join("| \\\n") + " \\\n" +
+                  t + $tab + '"' + "\n"
+              end
 
       t + "#{@name} [\n" +
         @options.to_a.filter_map { |i|
@@ -253,9 +255,11 @@ def to_s(t = '')
       hdr = t + "#{@dot_string} #{@name} {\n"
 
       options = @options.to_a.filter_map { |name, val|
-        val && name != 'label' ?
-          t + $tab + "#{name} = #{val}" :
+        if val && name != 'label'
+          t + $tab + "#{name} = #{val}"
+        else
           name ? t + $tab + "#{name} = \"#{val}\"" : nil
+        end
       }.join("\n") + "\n"
 
       nodes = @nodes.collect { |i|
@@ -292,9 +296,11 @@ def edge_link
     def to_s(t = '')
       t + "#{@from} #{edge_link} #{to} [\n" +
         @options.to_a.filter_map { |i|
-          i[1] && i[0] != 'label' ?
-            t + $tab + "#{i[0]} = #{i[1]}" :
+          if i[1] && i[0] != 'label'
+            t + $tab + "#{i[0]} = #{i[1]}"
+          else
             i[1] ? t + $tab + "#{i[0]} = \"#{i[1]}\"" : nil
+          end
         }.join("\n") + "\n#{t}]\n"
     end
   end

lib/puppet/module_tool/shared_behaviors.rb

@@ -135,7 +135,11 @@ def resolve_constraints(dependencies, source = [{ :name => :you }], seen = {}, a
         :action => action,
         :previous_version => @installed[mod].empty? ? nil : @installed[mod].first.version,
         :file => @urls["#{mod}@#{version[:vstring]}"],
-        :path => action == :install ? @options[:target_dir] : (@installed[mod].empty? ? @options[:target_dir] : @installed[mod].first.modulepath),
+        :path => if action == :install
+                   @options[:target_dir]
+                 else
+                   (@installed[mod].empty? ? @options[:target_dir] : @installed[mod].first.modulepath)
+                 end,
         :dependencies => []
       }
     end

lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb

@@ -120,7 +120,11 @@ def self.find_identity(rast)
   # Returns an Array; a tuple with method name and line number or "<unknown>" if either is missing, or format is not the expected
   #
   def self.extract_name_line(x)
-    (x.is_a?(Array) ? [x[1], x[2].is_a?(Array) ? x[2][1] : nil] : [nil, nil]).map { |v| v.nil? ? UNKNOWN : v }
+    (if x.is_a?(Array)
+       [x[1], x[2].is_a?(Array) ? x[2][1] : nil]
+     else
+       [nil, nil]
+     end).map { |v| v.nil? ? UNKNOWN : v }
   end
   private_class_method :extract_name_line
 end

lib/puppet/pops/lookup/hiera_config.rb

@@ -700,9 +700,13 @@ def create_configured_data_providers(lookup_invocation, parent_data_provider, us
                                          locations,
                                          {
                                            :hierarchy =>
-                                             locations.nil? ? [] : locations.map do |loc|
-                                               path = loc.original_location
-                                               path.end_with?(".#{function_name}") ? path[0..-(function_name.length + 2)] : path
+                                             if locations.nil?
+                                               []
+                                             else
+                                               locations.map do |loc|
+                                                 path = loc.original_location
+                                                 path.end_with?(".#{function_name}") ? path[0..-(function_name.length + 2)] : path
+                                               end
                                              end,
                                            function_name.to_sym => v3options,
                                            :backends => [function_name],

lib/puppet/pops/parser/lexer2.rb

@@ -268,7 +268,11 @@ def initialize
       '|' => lambda do
         scn = @scanner
         la = scn.peek(3)
-        emit(la[1] == '>' ? (la[2] == '>' ? TOKEN_RRCOLLECT : TOKEN_RCOLLECT) : TOKEN_PIPE, scn.pos)
+        emit(if la[1] == '>'
+               la[2] == '>' ? TOKEN_RRCOLLECT : TOKEN_RCOLLECT
+             else
+               TOKEN_PIPE
+             end, scn.pos)
       end,
 
       # TOKENS =, =>, ==, =~
@@ -635,7 +639,11 @@ def lex_unquoted_string(string, locator, escapes, interpolate)
     @scanner = StringScanner.new(string)
     @locator = locator || Locator.locator(string, '')
     @lexing_context[:escapes] = escapes || UQ_ESCAPES
-    @lexing_context[:uq_slurp_pattern] = interpolate ? (escapes.include?('$') ? SLURP_UQ_PATTERN : SLURP_UQNE_PATTERN) : SLURP_ALL_PATTERN
+    @lexing_context[:uq_slurp_pattern] = if interpolate
+                                           escapes.include?('$') ? SLURP_UQ_PATTERN : SLURP_UQNE_PATTERN
+                                         else
+                                           SLURP_ALL_PATTERN
+                                         end
   end
 
   # Convenience method, and for compatibility with older lexer. Use the lex_file instead.

lib/puppet/pops/types/string_converter.rb

@@ -119,7 +119,11 @@ def initialize(fmt)
 
       @left  = flags.include?('-')
       @alt   = flags.include?('#')
-      @plus  = (flags.include?(' ') ? :space : (flags.include?('+') ? :plus : :ignore))
+      @plus  = (if flags.include?(' ')
+                  :space
+                else
+                  (flags.include?('+') ? :plus : :ignore)
+                end)
       @zero_pad = flags.include?('0')
 
       @delimiters = nil

lib/puppet/pops/types/type_factory.rb

@@ -248,7 +248,11 @@ def self.tuple(types = [], size_type = nil)
   # @api public
   #
   def self.boolean(value = nil)
-    value.nil? ? PBooleanType::DEFAULT : (value ? PBooleanType::TRUE : PBooleanType::FALSE)
+    if value.nil?
+      PBooleanType::DEFAULT
+    else
+      (value ? PBooleanType::TRUE : PBooleanType::FALSE)
+    end
   end
 
   # Produces the Any type

lib/puppet/pops/types/types.rb

@@ -1088,7 +1088,11 @@ def each(&block)
   # numbers are converted to zero
   # @return [PIntegerType] a positive range
   def to_size
-    @from >= 0 ? self : PIntegerType.new(0, @to < 0 ? 0 : @to)
+    if @from >= 0
+      self
+    else
+      PIntegerType.new(0, @to < 0 ? 0 : @to)
+    end
   end
 
   def new_function

lib/puppet/util/log.rb

@@ -257,8 +257,11 @@ def Log.reopen
 
   def self.setup_default
     Log.newdestination(
-      (Puppet.features.syslog?   ? :syslog   :
-      (Puppet.features.eventlog? ? :eventlog : Puppet[:puppetdlog]))
+      (if Puppet.features.syslog?
+         :syslog
+       else
+         (Puppet.features.eventlog? ? :eventlog : Puppet[:puppetdlog])
+       end)
     )
   end