(PUP-11993) Style/RedundantSelf

This commit enables the Style/RedundantSelf cop and fixes
675 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -657,10 +657,6 @@ Style/PreferredHashMethods:
 Style/RedundantReturn:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantSelf:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit

lib/puppet/application.rb

@@ -187,7 +187,7 @@ def option(*options, &block)
           self.options[long.to_s.to_sym] = value
         end
       end
-      self.option_parser_commands << [options, fname]
+      option_parser_commands << [options, fname]
     end
 
     def banner(banner = nil)
@@ -261,7 +261,7 @@ def find(application_name)
     # @param [String] class_name the fully qualified name of the class to try to load
     # @return [Class] the Class instance, or nil? if it could not be loaded.
     def try_load_class(class_name)
-      return self.const_defined?(class_name) ? const_get(class_name) : nil
+      return const_defined?(class_name) ? const_get(class_name) : nil
     end
     private :try_load_class
 
@@ -553,14 +553,14 @@ def parse_options
     self.class.option_parser_commands.each do |options, fname|
       option_parser.on(*options) do |value|
         # Call the method that "option()" created.
-        self.send(fname, value)
+        send(fname, value)
       end
     end
 
     # Scan command line.  We just hand any exceptions to our upper levels,
     # rather than printing help and exiting, so that we can meaningfully
     # respond with context-sensitive help if we want to. --daniel 2011-04-12
-    option_parser.parse!(self.command_line.args)
+    option_parser.parse!(command_line.args)
   end
 
   def handlearg(opt, val)

lib/puppet/confine/variable.rb

@@ -29,7 +29,7 @@ def initialize(values)
   end
 
   def message(value)
-    "facter value '#{test_value}' for '#{self.name}' not in required list '#{values.join(",")}'"
+    "facter value '#{test_value}' for '#{name}' not in required list '#{values.join(",")}'"
   end
 
   # Compare the passed-in value to the retrieved value.

lib/puppet/confine_collection.rb

@@ -22,7 +22,7 @@ def confine(hash)
         confine.name = test
         @confines << confine
       end
-      @confines[-1].label = self.label
+      @confines[-1].label = label
     end
   end
 

lib/puppet/confiner.rb

@@ -33,7 +33,7 @@ def confine(hash)
   # @api private
   #
   def confine_collection
-    @confine_collection ||= Puppet::ConfineCollection.new(self.to_s)
+    @confine_collection ||= Puppet::ConfineCollection.new(to_s)
   end
 
   # Checks whether this implementation is suitable for the current platform (or returns a summary

lib/puppet/error.rb

@@ -98,7 +98,7 @@ def to_h
     def self.from_issue_and_stack(issue, args = {})
       filename, line = Puppet::Pops::PuppetStack.top_of_stack
 
-      self.new(
+      new(
         issue.format(args),
         filename,
         line,

lib/puppet/facter_impl.rb

@@ -58,7 +58,7 @@ def load_external?
     end
 
     def load_external(value)
-      ::Facter.load_external(value) if self.load_external?
+      ::Facter.load_external(value) if load_external?
     end
 
     private

lib/puppet/file_bucket/file.rb

@@ -73,7 +73,7 @@ def name
   end
 
   def self.from_binary(contents)
-    self.new(contents)
+    new(contents)
   end
 
   class StringContents

lib/puppet/file_serving/base.rb

@@ -76,7 +76,7 @@ def relative_path=(path)
 
   # Stat our file, using the appropriate link-sensitive method.
   def stat
-    @stat_method ||= self.links == :manage ? :lstat : :stat
+    @stat_method ||= links == :manage ? :lstat : :stat
     Puppet::FileSystem.send(@stat_method, full_path)
   end
 

lib/puppet/file_serving/fileset.rb

@@ -185,6 +185,6 @@ def valid?(path)
 
   def continue_recursion_at?(depth)
     # recurse if told to, and infinite recursion or current depth not at the limit
-    self.recurse && (self.recurselimit == :infinite || depth <= self.recurselimit)
+    recurse && (recurselimit == :infinite || depth <= recurselimit)
   end
 end