(PUP-11993) Style/RedundantFileExtensionInRequire

This commit enables the Style/RedundantFileExtensionInRequire cop
and fixes 4 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -664,14 +664,6 @@ Style/RedundantFetchBlock:
   Exclude:
     - 'lib/puppet/pops/types/p_sem_ver_range_type.rb'
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantFileExtensionInRequire:
-  Exclude:
-    - 'lib/puppet/parser.rb'
-    - 'lib/puppet/type/file/content.rb'
-    - 'lib/puppet/util/rdoc/parser.rb'
-    - 'lib/puppet/util/rdoc/parser/puppet_parser_rdoc2.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/RedundantInterpolation:
   Enabled: false

lib/puppet/parser.rb

@@ -16,7 +16,7 @@ module Puppet::Parser; end
 require_relative '../puppet/resource/type'
 require 'monitor'
 
-require_relative 'parser/compiler/catalog_validator/relationship_validator.rb'
+require_relative 'parser/compiler/catalog_validator/relationship_validator'
 
 # PUP-3274 This should probably go someplace else
 class Puppet::LexError < RuntimeError; end

lib/puppet/type/file/content.rb

@@ -5,7 +5,7 @@
 require 'tempfile'
 
 require_relative '../../../puppet/util/checksums'
-require_relative '../../../puppet/type/file/data_sync.rb'
+require_relative '../../../puppet/type/file/data_sync'
 
 module Puppet
   Puppet::Type.type(:file).newproperty(:content) do

lib/puppet/util/rdoc/parser.rb

@@ -11,4 +11,4 @@
 require 'rdoc/token_stream'
 require 'rdoc/markup/pre_process'
 require 'rdoc/parser'
-require_relative 'parser/puppet_parser_rdoc2.rb'
+require_relative 'parser/puppet_parser_rdoc2'

lib/puppet/util/rdoc/parser/puppet_parser_rdoc2.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../../../../puppet/util/rdoc/parser/puppet_parser_core.rb'
+require_relative '../../../../puppet/util/rdoc/parser/puppet_parser_core'
 
 module RDoc
   PUPPET_RDOC_VERSION = 2