Style/SlicingWithRange

Ruby 2.6 introduced endless ranges. This commit updates all ranges that
ended at -1 to instead by endless. This issue was identified by the
Rubocop Style/SlicingWithRange cop.

Author: mhashizume

lib/puppet/functions/getvar.rb

@@ -69,7 +69,7 @@ def get_from_navigation(scope, navigation, default_value = nil, &block)
     matches = navigation.match(/^((::)?(\w+::)*\w+)(.*)\z/)
     navigation = matches[4]
     if navigation[0] == '.'
-      navigation = navigation[1..-1]
+      navigation = navigation[1..]
     else
       unless navigation.empty?
         raise ArgumentError, _("First character after var name in get string must be a '.' - got %{char}") % { char: navigation[0] }

lib/puppet/module_tool/errors/shared.rb

@@ -106,15 +106,15 @@ def initialize(options)
       @requested_module  = options[:requested_module]
       @requested_version = options[:requested_version]
       @conditions        = options[:conditions]
-      @source            = options[:source][1..-1]
+      @source            = options[:source][1..]
 
       super _("'%{module_name}' (%{version}) requested; Invalid dependency cycle") % { module_name: @requested_module, version: v(@requested_version) }
     end
 
     def multiline
       dependency_list = []
       dependency_list << _("You specified '%{name}' (%{version})") % { name: @source.first[:name], version: v(@requested_version) }
-      dependency_list += @source[1..-1].map do |m|
+      dependency_list += @source[1..].map do |m|
         # TRANSLATORS This message repeats as separate lines as a list under the heading "You specified '%{name}' (%{version})\n"
         _("This depends on '%{name}' (%{version})") % { name: m[:name], version: v(m[:version]) }
       end

lib/puppet/network/http/api/indirected_routes.rb

@@ -57,7 +57,7 @@ def call(request, response)
 
   def uri2indirection(http_method, uri, params)
     # the first field is always nil because of the leading slash,
-    indirection_type, version, indirection_name, key = uri.split("/", 5)[1..-1]
+    indirection_type, version, indirection_name, key = uri.split("/", 5)[1..]
     url_prefix = "/#{indirection_type}/#{version}"
     environment = params.delete(:environment)
 

lib/puppet/network/http/connection.rb

@@ -266,7 +266,7 @@ def to_url(path)
 
   def normalize_path(path)
     if path[0] == '/'
-      path[1..-1]
+      path[1..]
     else
       path
     end

lib/puppet/parser/functions/sprintf.rb

@@ -45,7 +45,7 @@
   This statement produces a notice of `value is : 42`."
 ) do |args|
   fmt = args[0]
-  args = args[1..-1]
+  args = args[1..]
   begin
     return sprintf(fmt, *args)
   rescue KeyError => e

lib/puppet/parser/scope.rb

@@ -496,7 +496,7 @@ def lookupvar(name, options = EMPTY_HASH)
     # If name has '::' in it, it is resolved as a qualified variable
     unless (idx = name.index('::')).nil?
       # Always drop leading '::' if present as that is how the values are keyed.
-      return lookup_qualified_variable(idx == 0 ? name[2..-1] : name, options)
+      return lookup_qualified_variable(idx == 0 ? name[2..] : name, options)
     end
 
     # At this point, search is for a non qualified (simple) name
@@ -609,7 +609,7 @@ def lookup_qualified_variable(fqn, options)
     # not found - search inherited scope for class
     leaf_index = fqn.rindex('::')
     unless leaf_index.nil?
-      leaf_name = fqn[(leaf_index + 2)..-1]
+      leaf_name = fqn[(leaf_index + 2)..]
       class_name = fqn[0, leaf_index]
       begin
         qs = qualified_scope(class_name)
@@ -898,9 +898,9 @@ def to_s
     # check module paths first since they may be in the environment (i.e. they are longer)
     module_path = environment.full_modulepath.detect { |m_path| path.start_with?(m_path) }
     if module_path
-      path = "<module>" + path[module_path.length..-1]
+      path = "<module>" + path[module_path.length..]
     elsif env_path && path && path.start_with?(env_path)
-      path = "<env>" + path[env_path.length..-1]
+      path = "<env>" + path[env_path.length..]
     end
     # Make the output appear as "Scope(path, line)"
     "Scope(#{[path, detail[1]].join(', ')})"

lib/puppet/pops/evaluator/access_operator.rb

@@ -703,7 +703,7 @@ def access_PClassType(o, scope, keys)
 
         name = c.downcase
         # Remove leading '::' since all references are global, and 3x runtime does the wrong thing
-        name = name[2..-1] if name[0, 2] == NS
+        name = name[2..] if name[0, 2] == NS
 
         fail(Issues::ILLEGAL_NAME, @semantic.keys[i], { :name => c }) unless name =~ Patterns::NAME
 

lib/puppet/pops/evaluator/closure.rb

@@ -266,7 +266,7 @@ def combine_values_with_parameters(scope, args)
             given_argument = args[index]
             if param_captures
               # get excess arguments
-              value = args[(parameter_count - 1)..-1]
+              value = args[(parameter_count - 1)..]
               # If the input was a single nil, or undef, and there is a default, use the default
               # This supports :undef in case it was used in a 3x data structure and it is passed as an arg
               #

lib/puppet/pops/evaluator/deferred_resolver.rb

@@ -161,7 +161,7 @@ def resolve_future(f)
     mapped_arguments = map_arguments(f.arguments)
     # if name starts with $ then this is a call to dig
     if func_name[0] == DOLLAR
-      var_name = func_name[1..-1]
+      var_name = func_name[1..]
       func_name = DIG
       mapped_arguments.insert(0, @scope[var_name])
     end

lib/puppet/pops/evaluator/epp_evaluator.rb

@@ -86,7 +86,7 @@ def self.evaluate(parser, func_name, scope, use_global_scope_only, parse_result,
     filtered_args = {}
     template_args.each_pair do |k, v|
       if k =~ /::/
-        k = k[2..-1] if k.start_with?('::')
+        k = k[2..] if k.start_with?('::')
         scope[k] = v
       else
         filtered_args[k] = v