(PUP-11767) Fix auto-correctable Style/CaseEquality offenses

Author: tvpartytonight

.rubocop_todo.yml

@@ -346,9 +346,6 @@ Style/CaseEquality:
     - 'lib/puppet/interface/face_collection.rb'
     - 'lib/puppet/module_tool/installed_modules.rb'
     - 'lib/puppet/module_tool/shared_behaviors.rb'
-    - 'lib/puppet/provider/package/pip.rb'
-    - 'lib/puppet/provider/package/pkgin.rb'
-    - 'lib/puppet/settings/integer_setting.rb'
     - 'lib/puppet/util/command_line/puppet_option_parser.rb'
     - 'lib/puppet/util/log/destination.rb'
     - 'lib/puppet/util/multi_match.rb'

lib/puppet/provider/package/pip.rb

@@ -220,7 +220,7 @@ def get_install_command_options
     command_options += install_options if @resource[:install_options]
 
     if @resource[:source]
-      if String === should
+      if should.is_a?(String)
         command_options << "#{@resource[:source]}@#{should}#egg=#{@resource[:name]}"
       else
         command_options << "#{@resource[:source]}#egg=#{@resource[:name]}"
@@ -235,7 +235,7 @@ def get_install_command_options
       return command_options
     end
 
-    unless String === should
+    unless should.is_a?(String)
       command_options << @resource[:name]
 
       return command_options

lib/puppet/provider/package/pkgin.rb

@@ -64,7 +64,7 @@ def parse_pkgsearch_line
   end
 
   def install
-    if String === @resource[:ensure]
+    if @resource[:ensure].is_a?(String)
       pkgin("-y", :install, "#{resource[:name]}-#{resource[:ensure]}")
     else
       pkgin("-y", :install, resource[:name])

lib/puppet/settings/integer_setting.rb

@@ -2,7 +2,7 @@
 
 class Puppet::Settings::IntegerSetting < Puppet::Settings::BaseSetting
   def munge(value)
-    return value if Integer === value
+    return value if value.is_a?(Integer)
 
     begin
       value = Integer(value)

lib/puppet/util/command_line/puppet_option_parser.rb

@@ -70,7 +70,7 @@ def on(*args, &block)
         end
 
         def parse(*args)
-          args = args[0] if args.size == 1 and Array === args[0]
+          args = args[0] if args.size == 1 and args[0].is_a?(Array)
           args_copy = args.dup
           begin
             @parser.parse args_copy