(PUP-11764) DRY module integration tests

Also delete last remnants of the test forge

Author: joshcooper

acceptance/.beaker.yml

@@ -7,7 +7,6 @@ xml:                         true
 timesync:                    false
 repo_proxy:                  true
 add_el_extras:               false
-forge_host:                  api-forge-aio02-petest.puppet.com
 'master-start-curl-retries': 30
 log_level:                   debug
 preserve_hosts:              onfail

spec/integration/application/module_spec.rb

@@ -102,27 +102,39 @@
   end
 
   context 'changes' do
-    it 'reports an error when the install path is invalid' do
+    let(:tmp) { tmpdir('module_changes') }
+
+    before :each do
       Puppet.initialize_settings(['-E', 'direnv'])
       Puppet[:color] = false
+    end
+
+    def use_local_fixture
       Puppet[:environmentpath] = File.join(my_fixture_dir, 'environments')
-      dir = tmpdir('module_changes')
+    end
+
+    def create_working_copy
+      Puppet[:environmentpath] = File.join(tmp, 'environments')
+      FileUtils.cp_r(File.join(my_fixture_dir, 'environments'), tmp)
+    end
+
+    it 'reports an error when the install path is invalid' do
+      use_local_fixture
 
       pattern = Regexp.new([
-        %Q{.*Error: Could not find a valid module at "#{dir}/nginx".*},
+        %Q{.*Error: Could not find a valid module at "#{tmp}/nginx".*},
         %Q{.*Error: Try 'puppet help module changes' for usage.*},
       ].join("\n"), Regexp::MULTILINE)
 
       expect {
-        app.command_line.args = ['changes', File.join(dir, 'nginx')]
+        app.command_line.args = ['changes', File.join(tmp, 'nginx')]
         app.run
       }.to exit_with(1)
        .and output(pattern).to_stderr
     end
 
     it 'reports when checksums are missing from metadata.json' do
-      tmp = tmpdir('module_invalid_checksums')
-      FileUtils.cp_r(File.join(my_fixture_dir, 'environments'), tmp)
+      create_working_copy
 
       # overwrite checksums in metadata.json
       nginx_dir = File.join(tmp, 'environments', 'direnv', 'modules', 'nginx')
@@ -133,10 +145,6 @@
         }
       END
 
-      Puppet.initialize_settings(['-E', 'direnv'])
-      Puppet[:color] = false
-      Puppet[:environmentpath] = File.join(tmp, 'environments')
-
       pattern = Regexp.new([
         %Q{.*Error: No file containing checksums found.*},
         %Q{.*Error: Try 'puppet help module changes' for usage.*},
@@ -150,17 +158,12 @@
     end
 
     it 'reports module not found when metadata.json is missing' do
-      tmp = tmpdir('module_missing_metadata')
-      FileUtils.cp_r(File.join(my_fixture_dir, 'environments'), tmp)
+      create_working_copy
 
       # overwrite checksums in metadata.json
       nginx_dir = File.join(tmp, 'environments', 'direnv', 'modules', 'nginx')
       File.unlink(File.join(nginx_dir, 'metadata.json'))
 
-      Puppet.initialize_settings(['-E', 'direnv'])
-      Puppet[:color] = false
-      Puppet[:environmentpath] = File.join(tmp, 'environments')
-
       pattern = Regexp.new([
         %Q{.*Error: Could not find a valid module at.*},
         %Q{.*Error: Try 'puppet help module changes' for usage.*},
@@ -174,17 +177,12 @@
     end
 
     it 'reports when a file is modified' do
-      tmp = tmpdir('module_modified_metadata')
-      FileUtils.cp_r(File.join(my_fixture_dir, 'environments'), tmp)
+      create_working_copy
 
       # overwrite README so checksum doesn't match
       nginx_dir = File.join(tmp, 'environments', 'direnv', 'modules', 'nginx')
       File.write(File.join(nginx_dir, 'README'), '')
 
-      Puppet.initialize_settings(['-E', 'direnv'])
-      Puppet[:color] = false
-      Puppet[:environmentpath] = File.join(tmp, 'environments')
-
       pattern = Regexp.new([
         %Q{.*Warning: 1 files modified.*},
       ].join("\n"), Regexp::MULTILINE)
@@ -198,17 +196,12 @@
     end
 
     it 'reports when a file is missing' do
-      tmp = tmpdir('module_missing_file')
-      FileUtils.cp_r(File.join(my_fixture_dir, 'environments'), tmp)
+      create_working_copy
 
       # delete README so checksum doesn't match
       nginx_dir = File.join(tmp, 'environments', 'direnv', 'modules', 'nginx')
       File.unlink(File.join(nginx_dir, 'README'))
 
-      Puppet.initialize_settings(['-E', 'direnv'])
-      Puppet[:color] = false
-      Puppet[:environmentpath] = File.join(tmp, 'environments')
-
       # odd that it says modified
       pattern = Regexp.new([
         %Q{.*Warning: 1 files modified.*},
@@ -223,9 +216,8 @@
     end
 
     it 'reports when there are no changes' do
-      Puppet.initialize_settings(['-E', 'direnv'])
-      Puppet[:color] = false
-      Puppet[:environmentpath] = File.join(my_fixture_dir, 'environments')
+      use_local_fixture
+
       nginx_dir = File.join(Puppet[:environmentpath], 'direnv', 'modules', 'nginx')
 
       expect {