(PUP-11767) Fix HashTransformValues violations and remove from to_do

Author: tvpartytonight

.rubocop_todo.yml

@@ -504,15 +504,6 @@ Style/GuardClause:
 Style/HashSyntax:
   Enabled: false
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-Style/HashTransformValues:
-  Exclude:
-    - 'lib/puppet/functions/group_by.rb'
-    - 'lib/puppet/parser/scope.rb'
-    - 'lib/puppet/pops/loader/task_instantiator.rb'
-    - 'lib/puppet/pops/types/p_type_set_type.rb'
-    - 'lib/puppet/transaction/report.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/IdenticalConditionalBranches:
   Exclude:

lib/puppet/functions/group_by.rb

@@ -49,8 +49,8 @@ def group_by_2a(array)
       yield(k, v)
     end
 
-    grouped.each_with_object({}) do |(k, v), hsh|
-      hsh[k] = v.map { |item| item[1] }
+    grouped.transform_values do |v|
+      v.map { |item| item[1] }
     end.freeze
   end
 

lib/puppet/parser/scope.rb

@@ -260,7 +260,7 @@ def as_read_only
     end
 
     def to_hash
-      @params.select { |_, access| access.assigned? }.to_h { |name, access| [name, access.value] }
+      @params.select { |_, access| access.assigned? }.transform_values { |access| access.value }
     end
   end
 

lib/puppet/pops/loader/task_instantiator.rb

@@ -36,8 +36,8 @@ def self.create(loader, typed_name, source_refs)
   end
 
   def self.convert_types(args)
-    args.each_with_object({}) do |(k, v), hsh|
-      hsh[k] = v['type'].nil? ? Types::TypeFactory.data : Types::TypeParser.singleton.parse(v['type'])
+    args.transform_values do |v|
+      v['type'].nil? ? Types::TypeFactory.data : Types::TypeParser.singleton.parse(v['type'])
     end if args
   end
   private_class_method :convert_types

lib/puppet/pops/types/p_type_set_type.rb

@@ -183,7 +183,7 @@ def _pcore_init_hash
     result[KEY_NAME] = @name
     result[KEY_VERSION] = @version.to_s unless @version.nil?
     result[KEY_TYPES] = @types unless @types.empty?
-    result[KEY_REFERENCES] = @references.to_h { |ref_alias, ref| [ref_alias, ref._pcore_init_hash] } unless @references.empty?
+    result[KEY_REFERENCES] = @references.transform_values { |ref| ref._pcore_init_hash } unless @references.empty?
     result
   end
 

lib/puppet/transaction/report.rb

@@ -328,7 +328,7 @@ def calculate_resource_statuses
                         else
                           @resource_statuses
                         end
-    resource_statuses.to_h { |key, rs| [key, rs.nil? ? nil : rs.to_data_hash] }
+    resource_statuses.transform_values { |rs| rs.nil? ? nil : rs.to_data_hash }
   end
 
   def to_data_hash
@@ -345,7 +345,7 @@ def to_data_hash
       'noop_pending' => @noop_pending,
       'environment' => @environment,
       'logs' => @logs.map { |log| log.to_data_hash },
-      'metrics' => @metrics.to_h { |key, metric| [key, metric.to_data_hash] },
+      'metrics' => @metrics.transform_values { |metric| metric.to_data_hash },
       'resource_statuses' => calculate_resource_statuses,
       'corrective_change' => @corrective_change,
     }