(PUP-11767) Fix Style/For violations and remove from rubocop_todo

Author: tvpartytonight

.rubocop_todo.yml

@@ -463,15 +463,6 @@ Style/Encoding:
 Style/ExplicitBlockArgument:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: each, for
-Style/For:
-  Exclude:
-    - 'lib/puppet/file_system/uniquefile.rb'
-    - 'lib/puppet/module_tool/contents_description.rb'
-    - 'lib/puppet/util/rdoc/generators/puppet_generator.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: format, sprintf, percent

lib/puppet/file_system/uniquefile.rb

@@ -153,7 +153,7 @@ def try_convert_to_hash(h)
 
   def tmpdir
     tmp = '.'
-    for dir in [ENV.fetch('TMPDIR', nil), ENV.fetch('TMP', nil), ENV.fetch('TEMP', nil), @@systmpdir, '/tmp']
+    [ENV.fetch('TMPDIR', nil), ENV.fetch('TMP', nil), ENV.fetch('TEMP', nil), @@systmpdir, '/tmp'].each do |dir|
       stat = File.stat(dir) if dir
       if stat && stat.directory? && stat.writable?
         tmp = dir

lib/puppet/module_tool/contents_description.rb

@@ -32,12 +32,12 @@ def data
       unless @data
         @data = []
         type_names = []
-        for module_filename in Dir[File.join(@module_path, "lib/puppet/type/*.rb")]
+        (Dir[File.join(@module_path, "lib/puppet/type/*.rb")]).each do |module_filename|
           require module_filename
           type_name = File.basename(module_filename, ".rb")
           type_names << type_name
 
-          for provider_filename in Dir[File.join(@module_path, "lib/puppet/provider/#{type_name}/*.rb")]
+          (Dir[File.join(@module_path, "lib/puppet/provider/#{type_name}/*.rb")]).each do |provider_filename|
             require provider_filename
           end
         end

lib/puppet/util/rdoc/generators/puppet_generator.rb

@@ -323,7 +323,7 @@ def main_url
       end
 
       unless ref
-        for file in @files
+        @files.each do |file|
           if file.document_self and file.context.global
             ref = CGI.escapeHTML("#{CLASS_DIR}/#{file.context.module_name}.html")
             break
@@ -332,7 +332,7 @@ def main_url
       end
 
       unless ref
-        for file in @files
+        @files.each do |file|
           if file.document_self and !file.context.global
             ref = CGI.escapeHTML("#{CLASS_DIR}/#{file.context.module_name}.html")
             break