(PUP-11767) Fix EvenOdd violations and remove from rubocop_todo

Author: tvpartytonight

.rubocop_todo.yml

@@ -459,12 +459,6 @@ Style/Encoding:
     - 'lib/puppet/type/package.rb'
     - 'lib/puppet/util/windows/service.rb'
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/EvenOdd:
-  Exclude:
-    - 'lib/puppet/pops/serialization/json.rb'
-    - 'lib/puppet/pops/types/types.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/ExpandPathArguments:
   Exclude:

lib/puppet/pops/serialization/json.rb

@@ -182,7 +182,7 @@ def write_delim
         @nested.pop
         write_delim
       when Integer
-        if (cnt % 2) == 0 || !nesting[0]
+        if cnt.even? || !nesting[0]
           @io << ','
         else
           @io << ':'

lib/puppet/pops/types/types.rb

@@ -2841,7 +2841,7 @@ def from_array(from)
           if from.size == 0
             {}
           else
-            unless from.size % 2 == 0
+            unless from.size.even?
               raise TypeConversionError.new(_('odd number of arguments for Hash'))
             end