(PUP-11993) Style/RedundantSort

This commit enables the Style/RedundantSort cop and fixes 7 (unsafe)
autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -679,16 +679,6 @@ Style/RedundantSelfAssignment:
   Exclude:
     - 'lib/puppet/context.rb'
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-Style/RedundantSort:
-  Exclude:
-    - 'lib/puppet/interface/face_collection.rb'
-    - 'lib/puppet/module/plan.rb'
-    - 'lib/puppet/module_tool/applications/unpacker.rb'
-    - 'lib/puppet/provider/package/apt.rb'
-    - 'lib/puppet/provider/package/yum.rb'
-    - 'lib/puppet/provider/package/zypper.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed

lib/puppet/interface/face_collection.rb

@@ -55,7 +55,7 @@ def self.get_face(name, pattern)
   end
 
   def self.find_matching(range, versions)
-    versions.select { |v| range === v }.sort.last
+    versions.select { |v| range === v }.max
   end
 
   # try to load the face, and return it.
@@ -95,7 +95,7 @@ def self.load_face(name, version)
         # versions here and return the last item in that set.
         #
         # --daniel 2011-04-06
-        latest_ver = @faces[name].keys.sort.last
+        latest_ver = @faces[name].keys.max
         @faces[name][:current] = @faces[name][latest_ver]
       end
     end

lib/puppet/module/plan.rb

@@ -89,7 +89,7 @@ def self.find_implementations(name, plan_files)
       implementations = plan_files.select { |impl| File.basename(impl, '.*') == basename }
 
       # Select .pp before .yaml, since .pp comes before .yaml alphabetically.
-      chosen = implementations.sort.first
+      chosen = implementations.min
 
       [{ "name" => File.basename(chosen), "path" => chosen }]
     end

lib/puppet/module_tool/applications/unpacker.rb

@@ -64,7 +64,7 @@ def root_dir
         return @root_dir if @root_dir
 
         # Grab the first directory containing a metadata.json file
-        metadata_file = Dir["#{tmpdir}/**/metadata.json"].sort_by(&:length)[0]
+        metadata_file = Dir["#{tmpdir}/**/metadata.json"].min_by(&:length)
 
         if metadata_file
           @root_dir = Pathname.new(metadata_file).dirname

lib/puppet/provider/package/apt.rb

@@ -108,7 +108,7 @@ def best_version(should_range)
       end
     end
 
-    return versions.sort.last if versions.any?
+    return versions.max if versions.any?
 
     Puppet.debug("No available version for package #{@resource[:name]} is included in range #{should_range}")
     should_range

lib/puppet/provider/package/yum.rb

@@ -217,7 +217,7 @@ def best_version(should)
         Puppet.debug("Cannot parse #{version} as a RPM version")
       end
 
-      version = versions.sort.last if versions.any?
+      version = versions.max if versions.any?
 
       if version
         version = version.to_s.sub(/^\d+:/, '')

lib/puppet/provider/package/zypper.rb

@@ -82,7 +82,7 @@ def best_version(should)
         end
       end
 
-      return versions.sort.last if versions.any?
+      return versions.max if versions.any?
 
       Puppet.debug("No available version for package #{@resource[:name]} is included in range #{should_range}")
       should