Merge pull request #125 from glennsarti/fix-rubocop

(maint) Update for rubocop errors

Author: James Pogran

.rubocop.yml

@@ -83,3 +83,11 @@ Layout/AlignHash:
 
 Naming/RescuedExceptionsVariableName:
   PreferredName: e
+
+# There's no benefit to this and can make things harder to read.
+Style/NumericPredicate:
+  Enabled: false
+
+# This is not valid on Ruby 2.1
+Style/SafeNavigation:
+  Enabled: false

lib/debugserver/debug_protocol.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Original JSON Schema for the protocol
 # https://github.com/Microsoft/vscode-debugadapter-node/blob/master/debugProtocol.json
 #

lib/lsp/lsp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 %w[lsp_base lsp_enums lsp_protocol lsp_types lsp_custom].each do |lib|
   begin
     require "lsp/#{lib}"

lib/lsp/lsp_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module LSP

lib/lsp/lsp_custom.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Custom LSP Messages
 
 module LSP

lib/lsp/lsp_enums.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # DO NOT MODIFY. This file is built automatically
 # LSP Enumerations
 
@@ -14,8 +16,8 @@ module DiagnosticSeverity
   end
 
   module MarkupKind
-    PLAINTEXT = 'plaintext'.freeze
-    MARKDOWN = 'markdown'.freeze
+    PLAINTEXT = 'plaintext'
+    MARKDOWN = 'markdown'
   end
 
   module CompletionItemKind
@@ -87,13 +89,13 @@ module SymbolKind
   end
 
   module CodeActionKind
-    QUICKFIX = 'quickfix'.freeze
-    REFACTOR = 'refactor'.freeze
-    REFACTOREXTRACT = 'refactor.extract'.freeze
-    REFACTORINLINE = 'refactor.inline'.freeze
-    REFACTORREWRITE = 'refactor.rewrite'.freeze
-    SOURCE = 'source'.freeze
-    SOURCEORGANIZEIMPORTS = 'source.organizeImports'.freeze
+    QUICKFIX = 'quickfix'
+    REFACTOR = 'refactor'
+    REFACTOREXTRACT = 'refactor.extract'
+    REFACTORINLINE = 'refactor.inline'
+    REFACTORREWRITE = 'refactor.rewrite'
+    SOURCE = 'source'
+    SOURCEORGANIZEIMPORTS = 'source.organizeImports'
   end
 
   module TextDocumentSaveReason
@@ -103,16 +105,16 @@ module TextDocumentSaveReason
   end
 
   module ResourceOperationKind
-    CREATE = 'create'.freeze
-    RENAME = 'rename'.freeze
-    DELETE = 'delete'.freeze
+    CREATE = 'create'
+    RENAME = 'rename'
+    DELETE = 'delete'
   end
 
   module FailureHandlingKind
-    ABORT = 'abort'.freeze
-    TRANSACTIONAL = 'transactional'.freeze
-    TEXTONLYTRANSACTIONAL = 'textOnlyTransactional'.freeze
-    UNDO = 'undo'.freeze
+    ABORT = 'abort'
+    TRANSACTIONAL = 'transactional'
+    TEXTONLYTRANSACTIONAL = 'textOnlyTransactional'
+    UNDO = 'undo'
   end
 
   module TextDocumentSyncKind

lib/lsp/lsp_protocol.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # DO NOT MODIFY. This file is built automatically
 # LSP Protocol: vscode-languageserver-protocol/lib/protocol.d.ts
 

lib/lsp/lsp_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # DO NOT MODIFY. This file is built automatically
 # LSP Protocol: vscode-languageserver-types/lib/esm/main.d.ts
 

lib/puppet-debugserver/debug_hook_handlers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetDebugServer
   module PuppetDebugSession
     @hook_handler = nil

lib/puppet-debugserver/hooks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PuppetDebugServer
   # This code was inspired from Puppet-Debugger (https://raw.githubusercontent.com/nwops/puppet-debugger/master/lib/puppet-debugger/hooks.rb) which was borrowed from Pry hooks file