Skip to content

Commit 6ba8585

Browse files
committed
(GH-199) Update stack trace tests for Puppet 5.5.18
Previously in commit 074ad0b the stack trace handlers were modified for Puppet 6.11.0. That same change is now seen in Puppet 5.5.18. This commit modifies the test detection to also detect Puppet 5.5.18+.
1 parent 590804e commit 6ba8585

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

spec/debugserver/integration/puppet-debugserver/end_to_end_spec.rb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,12 @@
3333
}
3434

3535
def modified_puppet_stack_trace
36-
# Due to a modification to the way stack traces are treated in Puppet 6.11.0, the stack size is different
36+
# Due to a modification to the way stack traces are treated in Puppet 6.11.0 and 5.5.18, the stack size is different
3737
# See https://tickets.puppetlabs.com/browse/PUP-10150 for more infomation
38-
@modified_puppet_stack_trace ||= Gem::Version.create(Puppet.version) >= Gem::Version.create('6.11.0')
38+
pup_ver = Gem::Version.create(Puppet.version)
39+
return true if pup_ver >= Gem::Version.create('6.11.0')
40+
return true if pup_ver.canonical_segments.first == 5 && pup_ver >= Gem::Version.create('5.5.18')
41+
false
3942
end
4043

4144
context 'Processing an empty manifest with no breakpoints' do

0 commit comments

Comments
 (0)