(GH-139) Provide completions for defined types

Previously the manifest completion provider would not provide results if the
cursor was in a defined type. This commit adds the ResourceTypeDefinition much
like the HostClassDefinition.

Author: glennsarti

lib/puppet-languageserver/manifest/completion_provider.rb

@@ -41,8 +41,8 @@ def self.complete(content, line_num, char_num, options = {})
           # Complete for `$facts[...`
           all_facts { |x| items << x } if expr == 'facts'
 
-        when 'Puppet::Pops::Model::HostClassDefinition'
-          # We are in the root of a `class` statement
+        when 'Puppet::Pops::Model::HostClassDefinition', 'Puppet::Pops::Model::ResourceTypeDefinition'
+          # We are in the root of a `class` or `define` statement
 
           # Add keywords
           keywords(%w[require contain]) { |x| items << x }

spec/languageserver/integration/puppet-languageserver/manifest/completion_provider_spec.rb

@@ -131,6 +131,11 @@ class Alice {
   ensure => 'present',
   name   => 'name',
 }
+
+define delta (
+) {
+
+}
 EOT
       }
 
@@ -153,20 +158,24 @@ class Alice {
         end
       end
 
-      describe "When inside the root of a class" do
-        let(:line_num) { 1 }
-        let(:char_num) { 0 }
-        let(:expected_types) { ['keyword','resource_type','resource_class'] }
+      [
+        { :name => 'class', :line_num => 1 },
+        { :name => 'defined type', :line_num => 18 },
+      ].each do |testcase|
+        describe "When inside the root of a #{testcase[:name]}" do
+          let(:char_num) { 0 }
+          let(:expected_types) { ['keyword','resource_type','resource_class'] }
 
-        it 'should return a list of keyword, resource_type, resource_class' do
-          result = subject.complete(content, line_num, char_num)
+          it 'should return a list of keyword, resource_type, resource_class' do
+            result = subject.complete(content, testcase[:line_num], char_num)
 
-          result.items.each do |item|
-            expect(item).to be_completion_item_with_type(expected_types)
-          end
+            result.items.each do |item|
+              expect(item).to be_completion_item_with_type(expected_types)
+            end
 
-          expected_types.each do |typename|
-            expect(number_of_completion_item_with_type(result,typename)).to be > 0
+            expected_types.each do |typename|
+              expect(number_of_completion_item_with_type(result,typename)).to be > 0
+            end
           end
         end
       end