Skip to content

Commit 4691727

Browse files
committed
(maint) Extend delay for acceptance testing
Previously the acceptance tests were intermittently failing on Windows GitHub Actions runners. I really don't like this. But unfortunately the workspace symbol loading is asynchronous so you don't _really_ know what it's available. We could add another Request or extend puppet/getVersion to emit whether the workspace has been loaded yet. In the meantime just sleep a long time and hope it's loaded by then.
1 parent e4e1183 commit 4691727

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

spec/languageserver/acceptance/end_to_end_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,10 @@ def path_to_uri(path)
327327
expect(result['result']['dependencies']).not_to be_empty
328328

329329
# Workspace Symbols
330+
# TODO: I really don't like this. But unfortunately the workspace symbol loading is asynchronous so you don't _really_ know what it's available
331+
# We could add another Request or extend puppet/getVersion to emit whether the workspace has been loaded yet. In the meantime just sleep a long
332+
# time and hope it's loaded by then.
333+
sleep(15)
330334
@client.send_data(@client.workspace_symbols_request(@client.next_seq_id, ''))
331335
expect(@client).to receive_message_with_request_id_within_timeout([@client.current_seq_id, 15])
332336
result = @client.data_from_request_seq_id(@client.current_seq_id)

0 commit comments

Comments
 (0)