(maint) Refactor aggregate testing

Previously the tests use private instance methods to verify the object, however
the each_list method now does that. This commit changes the tests to use this
method instead.

Author: glennsarti

spec/languageserver-sidecar/integration/puppet-languageserver-sidecar/featureflag_puppetstrings/featureflag_puppetstrings_spec.rb

@@ -111,14 +111,10 @@ def expect_same_array_content(a, b)
       deserial2 = PuppetLanguageServer::Sidecar::Protocol::AggregateMetadata.new()
       expect { deserial2.from_json!(result2) }.to_not raise_error
 
-      deserial.class
-              .instance_methods(false)
-              .reject { |name| %i[to_json from_json! each_list append!].include?(name) }
-              .each do |method_name|
-        # There should be at least one item
-        expect(deserial.send(method_name).count).to be > 0
-        # Before and after should be the same
-        expect_same_array_content(deserial.send(method_name), deserial2.send(method_name))
+      deserial.each_list do |key, value|
+        # There should be at least one item per list in the aggregate
+        expect(value.count).to be > 0
+        expect_same_array_content(value, deserial2.send(key))
       end
     end
   end
@@ -270,7 +266,7 @@ def expect_same_array_content(a, b)
     describe 'when running workspace_aggregate action' do
       let (:cmd_options) { ['--action', 'workspace_aggregate', '--local-workspace', workspace] }
 
-      it 'should return a cachable deserializable aggregate object with all default metadata' do
+      it 'should return a cachable deserializable aggregate object with all workspace metadata' do
         expect_empty_cache
 
         result = run_sidecar(cmd_options)
@@ -286,14 +282,10 @@ def expect_same_array_content(a, b)
         deserial2 = PuppetLanguageServer::Sidecar::Protocol::AggregateMetadata.new()
         expect { deserial2.from_json!(result2) }.to_not raise_error
 
-        deserial.class
-                .instance_methods(false)
-                .reject { |name| %i[to_json from_json! each_list append!].include?(name) }
-                .each do |method_name|
-          # There should be at least one item
-          expect(deserial.send(method_name).count).to be > 0
-          # Before and after should be the same
-          expect_same_array_content(deserial.send(method_name), deserial2.send(method_name))
+        deserial.each_list do |key, value|
+          # There should be at least one item per list in the aggregate
+          expect(value.count).to be > 0
+          expect_same_array_content(value, deserial2.send(key))
         end
       end
     end
@@ -429,14 +421,10 @@ def expect_same_array_content(a, b)
         deserial2 = PuppetLanguageServer::Sidecar::Protocol::AggregateMetadata.new()
         expect { deserial2.from_json!(result2) }.to_not raise_error
 
-        deserial.class
-                .instance_methods(false)
-                .reject { |name| %i[to_json from_json! each_list append!].include?(name) }
-                .each do |method_name|
-          # There should be at least one item
-          expect(deserial.send(method_name).count).to be > 0
-          # Before and after should be the same
-          expect_same_array_content(deserial.send(method_name), deserial2.send(method_name))
+        deserial.each_list do |key, value|
+          # There should be at least one item per list in the aggregate
+          expect(value.count).to be > 0
+          expect_same_array_content(value, deserial2.send(key))
         end
       end
     end