(maint) Fix replying to invalid JSON RPC messages

Previously the reply_error method was removed which meant that when an invalid
message was passed, it would crash the editor service.  This commit re-adds the
missing method.

Author: glennsarti

lib/puppet_editor_services/protocol/json_rpc.rb

@@ -138,6 +138,7 @@ def receive_json_message_as_string(content)
       def receive_json_message_as_hash(json_obj)
         # There's no need to convert it to an object quite yet
         # Need to validate that this is indeed a valid message
+        id = json_obj[KEY_ID]
         unless json_obj[KEY_JSONRPC] == JSONRPC_VERSION
           PuppetEditorServices.log_message(:error, 'Invalid JSON RPC version')
           reply_error id, CODE_INVALID_REQUEST, MSG_INVALID_REQ_JSONRPC
@@ -159,7 +160,6 @@ def receive_json_message_as_hash(json_obj)
           end
         end
 
-        id = json_obj[KEY_ID]
         # Requests and Responses must have an ID that is either a string or integer
         if is_request || is_response
           unless id.is_a?(String) || id.is_a?(Integer)
@@ -197,6 +197,10 @@ def receive_json_message_as_hash(json_obj)
         false
       end
 
+      def reply_error(id, code, message)
+        send_json_string ::PuppetEditorServices::Protocol::JsonRPCMessages.reply_error_by_id(id, code, message).to_json
+      end
+
       # region Server-to-Client request/response methods
       def send_client_request(rpc_method, params)
         request = ::PuppetEditorServices::Protocol::JsonRPCMessages.new_request(client_request_id!, rpc_method, params)

lib/puppet_editor_services/protocol/json_rpc_messages.rb

@@ -169,10 +169,14 @@ def self.reply_result(request, result)
       end
 
       def self.reply_error(request, code, message)
+        reply_error_by_id(request.id, code, message)
+      end
+
+      def self.reply_error_by_id(id, code, message)
         # Note - Strictly speaking the error should be typed object, however as this hidden behind
         # this method it's easier to just pass in a known hash construct
         ResponseMessage.new.from_h!(
-          'id'    => request.id,
+          'id'    => id,
           'error' => {
             'code'    => code,
             'message' => message