Merge pull request #2733 from joshcooper/write_to_file

(FACT-3205) Ignore ENOENT when cleaning up temporary test files

Author: cthorn42

.rubocop.yml

@@ -53,27 +53,6 @@ Naming/VariableNumber:
     - 'lib/facter/resolvers/windows/ffi/networking_ffi.rb'
     - 'lib/facter/util/facts/windows_release_finder.rb'
 
-RSpec/MultipleMemoizedHelpers:
-  Enabled: false
-
-RSpec/StubbedMock:
-  Enabled: false
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-# $stdout is preferred because it refers to the *current* stdout stream, while
-# STDOUT refers to the original stream. However, we can't just switch to using
-# $stdout, because it may have been assigned to a different object than STDOUT,
-# such as a IO to a file.
-Style/GlobalStdStream:
-  Exclude:
-    - 'lib/facter.rb'
-    - 'lib/facter/framework/cli/cli_launcher.rb'
-    - 'lib/facter/framework/logging/logger.rb'
-    - 'spec/framework/core/fact/internal/internal_fact_manager_spec.rb'
-    - 'spec/framework/logging/logger_spec.rb'
-
 RSpec/DescribedClass:
   EnforcedStyle: explicit
 
@@ -94,6 +73,9 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/NestedGroups:
   Enabled: 6
 
+RSpec/StubbedMock:
+  Enabled: false
+
 RSpec/SubjectStub:
   Exclude:
     - 'spec/custom_facts/core/aggregate_spec.rb'
@@ -113,3 +95,18 @@ RSpec/VerifiedDoubles:
     - 'spec/facter/resolvers/windows/*'
     - 'spec/facter/util/windows/network_utils_spec.rb'
     - 'spec/facter/util/windows/win32ole_spec.rb'
+
+# $stdout is preferred because it refers to the *current* stdout stream, while
+# STDOUT refers to the original stream. However, we can't just switch to using
+# $stdout, because it may have been assigned to a different object than STDOUT,
+# such as a IO to a file.
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/facter.rb'
+    - 'lib/facter/framework/cli/cli_launcher.rb'
+    - 'lib/facter/framework/logging/logger.rb'
+    - 'spec/framework/core/fact/internal/internal_fact_manager_spec.rb'
+    - 'spec/framework/logging/logger_spec.rb'
+
+Style/IfUnlessModifier:
+  Enabled: false

spec/custom_facts/puppetlabs_spec/files.rb

@@ -27,7 +27,7 @@ def self.cleanup
         begin
           FileUtils.rm_r path, secure: true
         rescue Errno::ENOENT
-          puts 'failed to recursively delete files'
+          # nothing to do
         end
       end
     end