Fix function call read variables detection

Author: kylekatarnls

examples/scope-nested-call.js

@@ -0,0 +1,12 @@
+var method = 'foo';
+var obj = {
+    foo: function () {
+        return 'bar';
+    },
+};
+
+var foo = function () {
+    return obj[method]();
+};
+
+return foo();

examples/scope-nested-call.return

@@ -0,0 +1 @@
+bar

examples/scope-ternary.js

@@ -0,0 +1,13 @@
+var a = true;
+var b = [2];
+var c = 5;
+var d = 0;
+
+var func = function (e) {
+    return [a && !e ? b[d] : {c: c}];
+};
+
+var resultA = func(false);
+var resultB = func(true);
+
+return resultA[0] + resultB[0].c;

examples/scope-ternary.return

@@ -0,0 +1 @@
+7

src/JsPhpize/JsPhpize.php

@@ -68,7 +68,7 @@ public function compile($input, $filename = null)
         $block = $parser->parse();
         $php = $compiler->compile($block);
 
-        if ($this->flags & self::FLAG_TRUNCATED_PARENTHESES) {
+        if ($this->hasFlag(self::FLAG_TRUNCATED_PARENTHESES)) {
             $php = preg_replace('/\)[\s;]*$/', '', $php);
         }
 
@@ -87,6 +87,14 @@ public function compile($input, $filename = null)
         return preg_replace('/\{(\s*\}\s*\{)+$/', '{', $php);
     }
 
+    /**
+     * @return int
+     */
+    public function hasFlag($flag)
+    {
+        return $this->flags & $flag;
+    }
+
     /**
      * @param int  $flag    flag to set
      * @param bool $enabled flag state

src/JsPhpize/Nodes/FunctionCall.php

@@ -34,13 +34,10 @@ public function __construct(Value $function, array $arguments, array $children,
 
     public function getReadVariables()
     {
-        $variables = array();
+        $variables = $this->function->getReadVariables();
         foreach ($this->arguments as $argument) {
             $variables = array_merge($variables, $argument->getReadVariables());
         }
-        foreach ($this->children as $child) {
-            $variables = array_merge($variables, $child->getReadVariables());
-        }
 
         return $variables;
     }

tests/helpers.php

@@ -281,5 +281,15 @@ public function testDotHelperWithArrayPrototype()
             '246',
             $actual
         );
+
+        $jsPhpize = new JsPhpize();
+
+        $jsPhpize->setFlag(JsPhpize::FLAG_TRUNCATED_PARENTHESES, true);
+
+        self::assertEquals(true, $jsPhpize->hasFlag(JsPhpize::FLAG_TRUNCATED_PARENTHESES));
+
+        $jsPhpize->setFlag(JsPhpize::FLAG_TRUNCATED_PARENTHESES, false);
+
+        self::assertEquals(false, $jsPhpize->hasFlag(JsPhpize::FLAG_TRUNCATED_PARENTHESES));
     }
 }