chore: support clang-18 and ubuntu-24.04

These changes make Proxy-Wasm build cleanly with clang-18 and pass clang-tidy-18 checks.

Signed-off-by: Matt Leon <mattleon@google.com>

Author: leonm1

.bazelrc

@@ -10,6 +10,7 @@ build --action_env=PATH
 build:clang --action_env=BAZEL_COMPILER=clang
 build:clang --action_env=CC=clang
 build:clang --action_env=CXX=clang++
+build:clang --copt -Wno-pragma-once-outside-header --cxxopt -Wno-pragma-once-outside-header
 
 # Common flags for Clang sanitizers.
 build:clang-xsan --config=clang

.clang-tidy

@@ -1,24 +1,38 @@
 Checks:            clang-*,
+                   -clang-analyzer-core.CallAndMessage,
                    -clang-analyzer-optin.portability.UnixAPI,
                    -clang-analyzer-unix.Malloc,
                    -clang-diagnostic-pragma-once-outside-header,
+                   -clang-diagnostic-builtin-macro-redefined,
                    cppcoreguidelines-pro-type-member-init,
                    cppcoreguidelines-pro-type-static-cast-downcast,
                    misc-*,
                    -misc-non-private-member-variables-in-classes,
+                   -misc-use-anonymous-namespace,
+                   -misc-const-correctness,
+                   -misc-include-cleaner,
+                   -misc-unused-parameters,
                    modernize-*,
                    -modernize-avoid-c-arrays,
                    -modernize-use-trailing-return-type,
+                   -modernize-return-braced-init-list,
+                   -modernize-use-default-member-init,
+                   -modernize-type-traits,
+                   -modernize-use-emplace,
                    llvm-include-order,
                    performance-*,
                    -performance-no-int-to-ptr,
+                   -performance-avoid-endl,
                    portability-*,
                    readability-*,
                    -readability-convert-member-functions-to-static,
                    -readability-function-cognitive-complexity,
                    -readability-magic-numbers,
                    -readability-make-member-function-const,
                    -readability-simplify-boolean-expr,
-                   -clang-diagnostic-builtin-macro-redefined,
+                   -readability-identifier-length,
+                   -readability-container-data-pointer,
+                   -readability-redundant-casting,
+                   -readability-avoid-return-with-void-value,
 
 WarningsAsErrors:  '*'

.github/workflows/format.yml

@@ -43,7 +43,7 @@ jobs:
   addlicense:
     name: verify licenses
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -63,7 +63,7 @@ jobs:
   buildifier:
     name: check format with buildifier
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -101,29 +101,29 @@ jobs:
   clang_format:
     name: check format with clang-format
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-format-12
+      run: sudo apt update -y && sudo apt install -y clang-format-18
 
     - name: Format (clang-format)
       run: |
-        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-12 -i
+        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-18 -i
         git diff --exit-code
 
   clang_tidy:
     name: check format with clang-tidy
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-tidy-12 lld-12 && sudo ln -sf /usr/bin/lld-12 /usr/bin/lld
+      run: sudo apt update -y && sudo apt install -y clang-tidy-18 lld-18 && sudo ln -sf /usr/bin/lld-18 /usr/bin/lld
 
     - name: Bazel cache
       uses: PiotrSikora/cache@v2.1.7-with-skip-cache

.github/workflows/test.yml

@@ -43,7 +43,7 @@ jobs:
   test_data:
     name: build test data
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -111,19 +111,19 @@ jobs:
         include:
         - name: 'NullVM on Linux/x86_64'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=gcc
         - name: 'NullVM on Linux/x86_64 with ASan'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-asan --define=crypto=system
         - name: 'NullVM on Linux/x86_64 with TSan'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-tsan
@@ -136,39 +136,39 @@ jobs:
         - name: 'V8 on Linux/x86_64'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang --define=crypto=system
           cache: true
         - name: 'V8 on Linux/x86_64 with ASan'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-asan
           cache: true
         - name: 'V8 on Linux/x86_64 with TSan'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-tsan
           cache: true
         - name: 'V8 on Linux/x86_64 with GCC'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=gcc
           cache: true
         - name: 'V8 on Linux/aarch64'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: aarch64
           action: test
           targets: -//test/fuzz/...
@@ -185,7 +185,7 @@ jobs:
         - name: 'WAMR interp on Linux/x86_64'
           engine: 'wamr-interp'
           repo: 'com_github_bytecodealliance_wasm_micro_runtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
@@ -198,11 +198,11 @@ jobs:
         - name: 'WAMR jit on Linux/x86_64'
           engine: 'wamr-jit'
           repo: 'com_github_bytecodealliance_wasm_micro_runtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
-          deps: lld-12
+          deps: lld-18
           cache: true
         - name: 'WAMR jit on macOS/x86_64'
           engine: 'wamr-jit'
@@ -214,7 +214,7 @@ jobs:
         - name: 'WasmEdge on Linux/x86_64'
           engine: 'wasmedge'
           repo: 'com_github_wasmedge_wasmedge'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
@@ -227,29 +227,29 @@ jobs:
         - name: 'Wasmtime on Linux/x86_64'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang -c opt
         - name: 'Wasmtime on Linux/x86_64 with ASan'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-asan --define=crypto=system
         - name: 'Wasmtime on Linux/aarch64'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: aarch64
           action: build
           flags: --config=zig-cc-linux-aarch64
           deps: qemu-user-static libc6-arm64-cross
         - name: 'Wasmtime on Linux/s390x'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: s390x
           action: test
           flags: --config=clang --test_timeout=1800

bazel/external/bazel_clang_tidy.patch

@@ -1,5 +1,4 @@
 # 1. Treat .h files as C++ headers.
-# 2. Hardcode clang-tidy-12.
 
 diff --git a/clang_tidy/clang_tidy.bzl b/clang_tidy/clang_tidy.bzl
 index 3a5ed07..5db5c6c 100644
@@ -15,13 +14,3 @@ index 3a5ed07..5db5c6c 100644
      # start args passed to the compiler
      args.add("--")
 
-diff --git a/clang_tidy/run_clang_tidy.sh b/clang_tidy/run_clang_tidy.sh
-index 582bab1..b9ebb94 100755
---- a/clang_tidy/run_clang_tidy.sh
-+++ b/clang_tidy/run_clang_tidy.sh
-@@ -11,4 +11,4 @@ shift
- touch $OUTPUT
- truncate -s 0 $OUTPUT
- 
--clang-tidy "$@"
-+clang-tidy-12 "$@"

src/null/null_plugin.cc

@@ -26,7 +26,6 @@
 #include <utility>
 #include <vector>
 
-#include "include/proxy-wasm/null_plugin.h"
 #include "include/proxy-wasm/null_vm.h"
 #include "include/proxy-wasm/wasm.h"
 

src/wasmedge/wasmedge.cc

@@ -19,6 +19,7 @@
 
 #include "wasmedge/wasmedge.h"
 
+#include <algorithm>
 #include <array>
 #include <cassert>
 #include <cstring>

test/utility.cc

@@ -21,19 +21,18 @@ std::string TestContext::global_log_;
 std::vector<std::string> getWasmEngines() {
   std::vector<std::string> engines = {
 #if defined(PROXY_WASM_HOST_ENGINE_V8)
-    "v8",
+      "v8",
 #endif
 #if defined(PROXY_WASM_HOST_ENGINE_WAMR)
-    "wamr",
+      "wamr",
 #endif
 #if defined(PROXY_WASM_HOST_ENGINE_WASMEDGE)
-    "wasmedge",
+      "wasmedge",
 #endif
 #if defined(PROXY_WASM_HOST_ENGINE_WASMTIME)
-    "wasmtime",
+      "wasmtime",
 #endif
-    ""
-  };
+      ""};
   engines.pop_back();
   return engines;
 }