Skip to content

Commit 7028a8d

Browse files
authored
Merge pull request #42 from alexey-medvedchikov/fix-sigsegv-on-missing-credentials
Fix segmentation fault on missing credentials
2 parents c367079 + 3e94f01 commit 7028a8d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

stackdriver_exporter.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ func createMonitoringService() (*monitoring.Service, error) {
7676
ctx := context.Background()
7777

7878
googleClient, err := google.DefaultClient(ctx, monitoring.MonitoringReadScope)
79+
if err != nil {
80+
return nil, fmt.Errorf("Error creating Google client: %v", err)
81+
}
7982

8083
googleClient.Timeout = *stackdriverHttpTimeout
8184
googleClient.Transport = rehttp.NewTransport(
@@ -86,10 +89,6 @@ func createMonitoringService() (*monitoring.Service, error) {
8689
rehttp.ExpJitterDelay(*stackdriverBackoffJitterBase, *stackdriverMaxBackoffDuration), // Set timeout to <10s as that is prom default timeout
8790
)
8891

89-
if err != nil {
90-
return nil, fmt.Errorf("Error creating Google client: %v", err)
91-
}
92-
9392
monitoringService, err := monitoring.New(googleClient)
9493
if err != nil {
9594
return nil, fmt.Errorf("Error creating Google Stackdriver Monitoring service: %v", err)

0 commit comments

Comments
 (0)