Skip to content

Commit b0911c1

Browse files
committed
adding missing error checks
1 parent 1fe30e1 commit b0911c1

File tree

5 files changed

+23
-8
lines changed

5 files changed

+23
-8
lines changed

cmd/simplehttpserver/simplehttpserver.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ func main() {
1313
gologger.Fatal().Msgf("Could not create runner: %s\n", err)
1414
}
1515

16-
r.Run()
16+
if err := r.Run(); err != nil {
17+
gologger.Info().Msgf("%s\n", err)
18+
}
1719
defer r.Close()
1820
}

internal/runner/options.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"github.com/projectdiscovery/gologger/levels"
1111
)
1212

13+
// Options of the tool
1314
type Options struct {
1415
ListenAddress string
1516
Folder string
@@ -94,7 +95,7 @@ func (options *Options) configureOutput() {
9495
}
9596

9697
// FolderAbsPath of the fileserver folder
97-
func (o Options) FolderAbsPath() string {
98+
func (o *Options) FolderAbsPath() string {
9899
abspath, err := filepath.Abs(o.Folder)
99100
if err != nil {
100101
return o.Folder

internal/runner/runner.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,14 @@ func (r *Runner) Run() error {
8585
// Close the listening services
8686
func (r *Runner) Close() error {
8787
if r.serverTCP != nil {
88-
r.serverTCP.Close()
88+
if err := r.serverTCP.Close(); err != nil {
89+
return err
90+
}
8991
}
9092
if r.httpServer != nil {
91-
r.httpServer.Close()
93+
if err := r.httpServer.Close(); err != nil {
94+
return err
95+
}
9296
}
9397
return nil
9498
}

pkg/binder/binder.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"net"
66

77
"github.com/phayes/freeport"
8+
"github.com/projectdiscovery/gologger"
89
)
910

1011
// CanListenOn the specified address
@@ -13,7 +14,9 @@ func CanListenOn(address string) bool {
1314
if err != nil {
1415
return false
1516
}
16-
defer listener.Close()
17+
if err := listener.Close(); err != nil {
18+
gologger.Info().Msgf("%s\n", err)
19+
}
1720
return true
1821
}
1922

pkg/tcpserver/tcpserver.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ func (t *TCPServer) handleConnection(conn net.Conn) error {
5454

5555
buf := make([]byte, 4096)
5656
for {
57-
conn.SetReadDeadline(time.Now().Add(time.Duration(5 * time.Second)))
57+
if err := conn.SetReadDeadline(time.Now().Add(time.Duration(5 * time.Second))); err != nil {
58+
gologger.Info().Msgf("%s\n", err)
59+
}
5860
_, err := conn.Read(buf)
5961
if err != nil {
6062
return err
@@ -67,7 +69,9 @@ func (t *TCPServer) handleConnection(conn net.Conn) error {
6769
return err
6870
}
6971

70-
conn.Write(resp)
72+
if _, err := conn.Write(resp); err != nil {
73+
gologger.Info().Msgf("%s\n", err)
74+
}
7175

7276
gologger.Print().Msgf("%s\n", resp)
7377
}
@@ -106,10 +110,11 @@ func (t *TCPServer) run() error {
106110
if err != nil {
107111
return err
108112
}
109-
go t.handleConnection(c)
113+
go t.handleConnection(c) //nolint
110114
}
111115
}
112116

117+
// Close the service
113118
func (t *TCPServer) Close() error {
114119
return t.listener.Close()
115120
}

0 commit comments

Comments
 (0)